Commitdcf1d3a

authored

test(site): add e2e tests for experiments (#12940)

1 parentb163bc7 commitdcf1d3aCopy full SHA for dcf1d3a

File tree

+61

-5

lines changed

+61

-5

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,3 +37,7 @@ export const requireEnterpriseTests = Boolean(`
`37`	`37`	`process.env.CODER_E2E_REQUIRE_ENTERPRISE_TESTS,`
`38`	`38`	`);`
`39`	`39`	`exportconstenterpriseLicense=process.env.CODER_E2E_ENTERPRISE_LICENSE??"";`
	`40`	`+`
	`41`	`+// Fake experiments to verify that site presents them as enabled.`
	`42`	`+exportconste2eFakeExperiment1="e2e-fake-experiment-1";`
	`43`	`+exportconste2eFakeExperiment2="e2e-fake-experiment-2";`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,13 @@`
`1`	`1`	`import{defineConfig}from"@playwright/test";`
`2`	`2`	`import*aspathfrom"path";`
`3`		`-import{coderMain,coderPort,coderdPProfPort,gitAuth}from"./constants";`
	`3`	`+import{`
	`4`	`+coderMain,`
	`5`	`+coderPort,`
	`6`	`+coderdPProfPort,`
	`7`	`+e2eFakeExperiment1,`
	`8`	`+e2eFakeExperiment2,`
	`9`	`+gitAuth,`
	`10`	`+}from"./constants";`
`4`	`11`
`5`	`12`	`exportconstwsEndpoint=process.env.CODER_E2E_WS_ENDPOINT;`
`6`	`13`
`@@ -22,7 +29,7 @@ export default defineConfig({`
`22`	`29`	`testMatch:/.*\.spec\.ts/,`
`23`	`30`	`dependencies:["testsSetup"],`
`24`	`31`	`use:{ storageState},`
`25`		`-timeout:20_000,`
	`32`	`+timeout:50_000,`
`26`	`33`	`},`
`27`	`34`	`],`
`28`	`35`	`reporter:[["./reporter.ts"]],`
`@@ -60,6 +67,8 @@ export default defineConfig({`
`60`	`67`	`.join(" "),`
`61`	`68`	`env:{`
`62`	`69`	`...process.env,`
	`70`	`+// Otherwise, the runner fails on Mac with: could not determine kind of name for C.uuid_string_t`
	`71`	`+CGO_ENABLED:"0",`
`63`	`72`
`64`	`73`	`// This is the test provider for git auth with devices!`
`65`	`74`	`CODER_GITAUTH_0_ID:gitAuth.deviceProvider,`
`@@ -101,6 +110,7 @@ export default defineConfig({`
`101`	`110`	`gitAuth.validatePath,`
`102`	`111`	`),`
`103`	`112`	`CODER_PPROF_ADDRESS:"127.0.0.1:"+coderdPProfPort,`
	`113`	`+CODER_EXPERIMENTS:e2eFakeExperiment1+","+e2eFakeExperiment2,`
`104`	`114`	`},`
`105`	`115`	`reuseExistingServer:false,`
`106`	`116`	`},`

Lines changed: 39 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,39 @@`
	`1`	`+import{expect,test}from"@playwright/test";`
	`2`	`+import*asAPIfrom"api/api";`
	`3`	`+import{setupApiCalls}from"../../api";`
	`4`	`+import{e2eFakeExperiment1,e2eFakeExperiment2}from"../../constants";`
	`5`	`+`
	`6`	`+test("experiments",async({ page})=>{`
	`7`	`+awaitsetupApiCalls(page);`
	`8`	`+`
	`9`	`+// Load experiments from backend API`
	`10`	`+constavailableExperiments=awaitAPI.getAvailableExperiments();`
	`11`	`+`
	`12`	`+// Verify if the site lists the same experiments`
	`13`	`+awaitpage.goto("/deployment/general",{waitUntil:"networkidle"});`
	`14`	`+`
	`15`	`+constexperimentsLocator=page.locator(`
	`16`	`+"div.options-table tr.option-experiments ul.option-array",`
	`17`	`+);`
	`18`	`+awaitexpect(experimentsLocator).toBeVisible();`
	`19`	`+`
	`20`	`+// Firstly, check if all enabled experiments are listed`
	`21`	`+expect(`
	`22`	`+experimentsLocator.locator(`
	`23`	+`li.option-array-item-${e2eFakeExperiment1}.option-enabled`,
	`24`	`+),`
	`25`	`+).toBeVisible;`
	`26`	`+expect(`
	`27`	`+experimentsLocator.locator(`
	`28`	+`li.option-array-item-${e2eFakeExperiment2}.option-enabled`,
	`29`	`+),`
	`30`	`+).toBeVisible;`
	`31`	`+`
	`32`	`+// Secondly, check if available experiments are listed`
	`33`	`+for(constexperimentofavailableExperiments.safe){`
	`34`	`+constexperimentLocator=experimentsLocator.locator(`
	`35`	+`li.option-array-item-${experiment}`,
	`36`	`+);`
	`37`	`+awaitexpect(experimentLocator).toBeVisible();`
	`38`	`+}`
	`39`	`+});`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export const OptionValue: FC<OptionValueProps> = (props) => {`
`51`	`51`
`52`	`52`	`if(typeofvalue==="object"&&!Array.isArray(value)){`
`53`	`53`	`return(`
`54`		`-<ulcss={{listStyle:"none"}}>`
	`54`	`+<ulcss={{listStyle:"none"}}className="option-array">`
`55`	`55`	`{Object.entries(value)`
`56`	`56`	`.sort((a,b)=>a[0].localeCompare(b[0]))`
`57`	`57`	`.map(([option,isEnabled])=>(`
`@@ -64,6 +64,9 @@ export const OptionValue: FC<OptionValueProps> = (props) => {`
`64`	`64`	`color:theme.palette.text.disabled,`
`65`	`65`	`},`
`66`	`66`	`]}`
	`67`	+className={`option-array-item-${option}${
	`68`	`+isEnabled ?"option-enabled" :"option-disabled"`
	`69`	+}`}
`67`	`70`	`>`
`68`	`71`	`<div`
`69`	`72`	`css={{`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`return(`
`30`		`-<TableContainer>`
	`30`	`+<TableContainerclassName="options-table">`
`31`	`31`	`<Table`
`32`	`32`	css={css`
`33`	`33`	`&td {`
`@@ -57,7 +57,7 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {`
`57`	`57`	`returnnull;`
`58`	`58`	`}`
`59`	`59`	`return(`
`60`		`-<TableRowkey={option.flag}>`
	`60`	`+<TableRowkey={option.flag}className={"option-"+option.flag}>`
`61`	`61`	`<TableCell>`
`62`	`62`	`<OptionName>{option.name}</OptionName>`
`63`	`63`	`<OptionDescription>{option.description}</OptionDescription>`

Comments

(0)