NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commitdc69341

authored

fix: make public menu item selectable (#12484)

1 parent5e9bf31 commitdc69341Copy full SHA for dc69341

File tree

1 file changed

+19

-17

lines changed

site/src/modules/resources
- PortForwardButton.tsx

1 file changed

+19

-17

lines changed

`‎site/src/modules/resources/PortForwardButton.tsx`

Lines changed: 19 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -205,21 +205,15 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({`
`205`	`205`	`constcanSharePortsPublic=`
`206`	`206`	`canSharePorts&&template.max_port_share_level==="public";`
`207`	`207`
`208`		`-constpublicMenuItem=(`
`209`		`-<>`
`210`		`-{canSharePortsPublic ?(`
`211`		`-<MenuItemvalue="public">Public</MenuItem>`
`212`		`-) :(`
`213`		`-<Tooltiptitle="This workspace template does not allow sharing ports with unauthenticated users.">`
`214`		`-{/* Tooltips don't work directly on disabled MenuItem components so you must wrap in div. */}`
`215`		`-<div>`
`216`		`-<MenuItemvalue="public"disabled>`
`217`		`- Public`
`218`		`-</MenuItem>`
`219`		`-</div>`
`220`		`-</Tooltip>`
`221`		`-)}`
`222`		`-</>`
	`208`	`+constdisabledPublicMenuItem=(`
	`209`	`+<Tooltiptitle="This workspace template does not allow sharing ports with unauthenticated users.">`
	`210`	`+{/* Tooltips don't work directly on disabled MenuItem components so you must wrap in div. */}`
	`211`	`+<div>`
	`212`	`+<MenuItemvalue="public"disabled>`
	`213`	`+ Public`
	`214`	`+</MenuItem>`
	`215`	`+</div>`
	`216`	`+</Tooltip>`
`223`	`217`	`);`
`224`	`218`
`225`	`219`	`return(`
`@@ -447,7 +441,11 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({`
`447`	`441`	`<MenuItemvalue="authenticated">`
`448`	`442`	`Authenticated`
`449`	`443`	`</MenuItem>`
`450`		`-{publicMenuItem}`
	`444`	`+{canSharePortsPublic ?(`
	`445`	`+<MenuItemvalue="public">Public</MenuItem>`
	`446`	`+) :(`
	`447`	`+disabledPublicMenuItem`
	`448`	`+)}`
`451`	`449`	`</Select>`
`452`	`450`	`</FormControl>`
`453`	`451`	`<Button`
`@@ -512,7 +510,11 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({`
`512`	`510`	`label="Sharing Level"`
`513`	`511`	`>`
`514`	`512`	`<MenuItemvalue="authenticated">Authenticated</MenuItem>`
`515`		`-{publicMenuItem}`
	`513`	`+{canSharePortsPublic ?(`
	`514`	`+<MenuItemvalue="public">Public</MenuItem>`
	`515`	`+) :(`
	`516`	`+disabledPublicMenuItem`
	`517`	`+)}`
`516`	`518`	`</TextField>`
`517`	`519`	`<LoadingButton`
`518`	`520`	`variant="contained"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdc69341

File tree

1 file changed

1 file changed

`‎site/src/modules/resources/PortForwardButton.tsx`

0 commit comments