- Notifications
You must be signed in to change notification settings - Fork906
Commitd8561a6
authored
ci: avoid cancelling other nightly-gauntlet jobs on failure (#16795)
I saw in a failing nightly-gauntlet that the macOS+Postgres testsfailing caused the Windows tests to get cancelled:https://github.com/coder/coder/actions/runs/13645971060There's no harm in letting the other test run, and will let us catchadditional flakes & failures. If one job fails, the whole matrix willstill fail (once the remaining tests in the matrix have completed) andthe slack notification will still be sent.[We previously made thischange](#8624) on our on-push `ci`workflow.Relevant documentation:> jobs.<job_id>.strategy.fail-fast applies to the entire matrix. Ifjobs.<job_id>.strategy.fail-fast is set to true or its expressionevaluates to true, GitHub will cancel all in-progress and queued jobs inthe matrix if any job in the matrix fails. This property defaults totrue.https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast1 parent17ad284 commitd8561a6
1 file changed
+1
-0
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
0 commit comments
Comments
(0)