NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.4k

Commitd306a2d

authored

chore: log with %s on unexpected non-sdk err (#20570)

With `%w` it prints an address instead of the error, like `<op> <url>0xc001329370` instead of `<op> <url>: some error`, honestly idk why youeven can log with `%w` it seems like it makes no sense to use `%w`outside of `fmt.Errorf`.This is to help debugcoder/internal#1010.

1 parent30d2fc8 commitd306a2dCopy full SHA for d306a2d

File tree

1 file changed

-1

lines changed

coderd/coderdtest
- coderdtest.go

1 file changed

-1

lines changed

`‎coderd/coderdtest/coderdtest.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1604,7 +1604,7 @@ func (nopcloser) Close() error { return nil }`
`1604`	`1604`	`// SDKError coerces err into an SDK error.`
`1605`	`1605`	`funcSDKError(t testing.TB,errerror)*codersdk.Error {`
`1606`	`1606`	`varcerr*codersdk.Error`
`1607`		`-require.True(t,errors.As(err,&cerr),"should be SDK error, got %w",err)`
	`1607`	`+require.True(t,errors.As(err,&cerr),"should be SDK error, got %s",err)`
`1608`	`1608`	`returncerr`
`1609`	`1609`	`}`
`1610`	`1610`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd306a2d

File tree

1 file changed

1 file changed

`‎coderd/coderdtest/coderdtest.go‎`

0 commit comments