Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitd2a74cf

Browse files
authored
fix: display tooltip when selection is disabled (#12439)
1 parent586586e commitd2a74cf

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

‎site/src/modules/resources/PortForwardButton.tsx

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import MenuItem from "@mui/material/MenuItem";
1414
importSelectfrom"@mui/material/Select";
1515
importStackfrom"@mui/material/Stack";
1616
importTextFieldfrom"@mui/material/TextField";
17+
importTooltipfrom"@mui/material/Tooltip";
1718
import{typeFormikContextType,useFormik}from"formik";
1819
importtype{FC}from"react";
1920
import{useQuery,useMutation}from"react-query";
@@ -204,6 +205,23 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
204205
constcanSharePortsPublic=
205206
canSharePorts&&template.max_port_share_level==="public";
206207

208+
constpublicMenuItem=(
209+
<>
210+
{canSharePortsPublic ?(
211+
<MenuItemvalue="public">Public</MenuItem>
212+
) :(
213+
<Tooltiptitle="This workspace template does not allow sharing ports with unauthenticated users.">
214+
{/* Tooltips don't work directly on disabled MenuItem components so you must wrap in div. */}
215+
<div>
216+
<MenuItemvalue="public"disabled>
217+
Public
218+
</MenuItem>
219+
</div>
220+
</Tooltip>
221+
)}
222+
</>
223+
);
224+
207225
return(
208226
<>
209227
<div
@@ -429,12 +447,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
429447
<MenuItemvalue="authenticated">
430448
Authenticated
431449
</MenuItem>
432-
<MenuItem
433-
value="public"
434-
disabled={!canSharePortsPublic}
435-
>
436-
Public
437-
</MenuItem>
450+
{publicMenuItem}
438451
</Select>
439452
</FormControl>
440453
<Button
@@ -499,9 +512,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
499512
label="Sharing Level"
500513
>
501514
<MenuItemvalue="authenticated">Authenticated</MenuItem>
502-
<MenuItemvalue="public"disabled={!canSharePortsPublic}>
503-
Public
504-
</MenuItem>
515+
{publicMenuItem}
505516
</TextField>
506517
<LoadingButton
507518
variant="contained"

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp