Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitd25ff6c

Browse files
authored
docs: add guidelines about PR size (#19700)
Adds guidelines about PR size to our contributing guide.
1 parentdae1903 commitd25ff6c

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

‎docs/about/contributing/CONTRIBUTING.md‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,32 @@ channel.
148148

149149
- [Frontend styling guide](./frontend.md#styling)
150150

151+
## Pull Requests
152+
153+
We welcome pull requests (PRs) from community members including (but not limited to) opensource users, enthusiasts, and enterprise customers.
154+
155+
We will ask that you sign a Contributor License Agreement before we accept any contributions into our repo.
156+
157+
Please keep PRs small and self-contained. This allows code reviewers (see below) to focus and fully understand the PR. A good rule of thumb is less than 1000 lines changed. (One exception is a mechanistic refactor, like renaming, that is conceptually trivial but might have a large line count.)
158+
159+
If your intended feature or refactor will be larger than this:
160+
161+
1. Open an issue explaining what you intend to build, how it will work, and that you are volunteering todo the development. Include`@coder/community-triage`in the body.
162+
2. Give the maintainers a chance to respond. Changes to the visual, interaction, or software design are easier to adjust before you start laying down code.
163+
3. Break your work up into a series of smaller PRs.
164+
165+
Stacking tools like [Graphite](https://www.graphite.dev) are usefulfor keeping a series of PRs that build on each other up to date as they are reviewed and merged.
166+
167+
Each PR:
168+
169+
- Must individually build and pass all tests, including formatting and linting.
170+
- Must not introduce regressions or backward-compatibility issues, evenif a subsequent PRin your series would resolve the issue.
171+
- Should be a conceptually coherent change set.
172+
173+
In practice, many of these smaller PRs will be invisible to end users, and that is ok. For example, you might introduce
174+
a new Go package that implements the core business logic of a featurein one PR, but only later actually"wire it up"
175+
to a new API routein a later PR. Or, you might implement a new React componentin one PR, and onlyin a later PR place it on a page.
176+
151177
## Reviews
152178

153179
The following information has been borrowed from [Go's review philosophy](https://go.dev/doc/contribute#reviews).

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp