Commitd18e830

authored

fix: reduce parallelism and increase worker size on go-test-race (#15106)

Sets parallelism on go-test-race to 4 concurrent tests and 4 concurrentpackages. Increases to 16-core runner.

1 parent7f98fa3 commitd18e830Copy full SHA for d18e830

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -466,7 +466,7 @@ jobs:`
`466`	`466`	`api-key:${{ secrets.DATADOG_API_KEY }}`
`467`	`467`
`468`	`468`	`test-go-race:`
`469`		`-runs-on:${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' \|\| 'ubuntu-latest' }}`
	`469`	`+runs-on:${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-16' \|\| 'ubuntu-latest' }}`
`470`	`470`	`needs:changes`
`471`	`471`	`if:needs.changes.outputs.go == 'true' \|\| needs.changes.outputs.ci == 'true' \|\| github.ref == 'refs/heads/main'`
`472`	`472`	`timeout-minutes:25`
`@@ -487,9 +487,13 @@ jobs:`
`487`	`487`	`-name:Setup Terraform`
`488`	`488`	`uses:./.github/actions/setup-tf`
`489`	`489`
	`490`	`+# We run race tests with reduced parallelism because they use more CPU and we were finding`
	`491`	`+# instances where tests appear to hang for multiple seconds, resulting in flaky tests when`
	`492`	`+# short timeouts are used.`
	`493`	`+# c.f. discussion on https://github.com/coder/coder/pull/15106`
`490`	`494`	`-name:Run Tests`
`491`	`495`	`run:\|`
`492`		`- gotestsum --junitfile="gotests.xml" -- -race ./...`
	`496`	`+ gotestsum --junitfile="gotests.xml" -- -race-parallel 4 -p 4./...`
`493`	`497`
`494`	`498`	`-name:Upload test stats to Datadog`
`495`	`499`	`timeout-minutes:1`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -817,7 +817,7 @@ test-postgres-docker:`
`817`	`817`
`818`	`818`	`# Make sure to keep this in sync with test-go-race from .github/workflows/ci.yaml.`
`819`	`819`	`test-race:`
`820`		`-$(GIT_FLAGS) gotestsum --junitfile="gotests.xml" -- -race -count=1 ./...`
	`820`	`+$(GIT_FLAGS) gotestsum --junitfile="gotests.xml" -- -race -count=1-parallel 4 -p 4./...`
`821`	`821`	`.PHONY: test-race`
`822`	`822`
`823`	`823`	`test-tailnet-integration:`

Comments

(0)