Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitcf8deb0

Browse files
committed
restart and ephemeral parameters resolved
1 parentd6a2262 commitcf8deb0

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

‎cli/restart.go‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,17 @@ func (r *RootCmd) restart() *serpent.Command {
5151
returnerr
5252
}
5353

54+
stopParamValues,err:=asWorkspaceBuildParameters(parameterFlags.ephemeralParameters)
55+
iferr!=nil {
56+
returnxerrors.Errorf("parse ephemeral parameters: %w",err)
57+
}
5458
wbr:= codersdk.CreateWorkspaceBuildRequest{
5559
Transition:codersdk.WorkspaceTransitionStop,
60+
// Ephemeral parameters should be passed to both stop and start builds.
61+
// TODO: maybe these values should be sourced from the previous build?
62+
// It has to be manually sourced, as ephermeral parameters do not carry across
63+
// builds.
64+
RichParameterValues:stopParamValues,
5665
}
5766
ifbflags.provisionerLogDebug {
5867
wbr.LogLevel=codersdk.ProvisionerLogLevelDebug

‎cli/restart_test.go‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,11 @@ func TestRestart(t *testing.T) {
7171
version:=coderdtest.CreateTemplateVersion(t,client,owner.OrganizationID,echoResponses())
7272
coderdtest.AwaitTemplateVersionJobCompleted(t,client,version.ID)
7373
template:=coderdtest.CreateTemplate(t,client,owner.OrganizationID,version.ID)
74-
workspace:=coderdtest.CreateWorkspace(t,member,template.ID)
74+
workspace:=coderdtest.CreateWorkspace(t,member,template.ID,func(request*codersdk.CreateWorkspaceRequest) {
75+
request.RichParameterValues= []codersdk.WorkspaceBuildParameter{
76+
{Name:ephemeralParameterName,Value:"placeholder"},
77+
}
78+
})
7579
coderdtest.AwaitWorkspaceBuildJobCompleted(t,client,workspace.LatestBuild.ID)
7680

7781
inv,root:=clitest.New(t,"restart",workspace.Name,"--prompt-ephemeral-parameters")
@@ -125,7 +129,11 @@ func TestRestart(t *testing.T) {
125129
version:=coderdtest.CreateTemplateVersion(t,client,owner.OrganizationID,echoResponses())
126130
coderdtest.AwaitTemplateVersionJobCompleted(t,client,version.ID)
127131
template:=coderdtest.CreateTemplate(t,client,owner.OrganizationID,version.ID)
128-
workspace:=coderdtest.CreateWorkspace(t,member,template.ID)
132+
workspace:=coderdtest.CreateWorkspace(t,member,template.ID,func(request*codersdk.CreateWorkspaceRequest) {
133+
request.RichParameterValues= []codersdk.WorkspaceBuildParameter{
134+
{Name:ephemeralParameterName,Value:"placeholder"},
135+
}
136+
})
129137
coderdtest.AwaitWorkspaceBuildJobCompleted(t,client,workspace.LatestBuild.ID)
130138

131139
inv,root:=clitest.New(t,"restart",workspace.Name,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp