Commitcee93cb

committed

Review comments

Signed-off-by: Danny Kopping <danny@coder.com>

1 parente868752 commitcee93cbCopy full SHA for cee93cb

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`ALTERTABLE notification_messages`
`2`		`-ADD COLUMN queued_secondsFLOATNULL;`
	`2`	`+ADD COLUMN queued_secondsINTEGERNULL;`

Lines changed: 1 addition & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func NewMetrics(reg prometheus.Registerer) *Metrics {`
`48`	`48`	`// Aggregating on LabelTemplateID as well would cause a cardinality explosion.`
`49`	`49`	`QueuedSeconds:promauto.With(reg).NewHistogramVec(prometheus.HistogramOpts{`
`50`	`50`	`Name:"queued_seconds",Namespace:ns,Subsystem:subsystem,`
`51`		`-Buckets: []float64{0.1,1,5,15,30,60,120,300,600,3600,86400},`
	`51`	`+Buckets: []float64{1,5,15,30,60,120,300,600,3600,86400},`
`52`	`52`	`Help:"The time elapsed between a notification being enqueued in the store and retrieved for processing "+`
`53`	`53`	`"(measures the latency of the notifications system). This should generally be within CODER_NOTIFICATIONS_FETCH_INTERVAL "+`
`54`	`54`	`"seconds; higher values for a sustained period indicates delayed processing and CODER_NOTIFICATIONS_LEASE_COUNT "+`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,8 @@ func TestMetrics(t *testing.T) {`
`28`	`28`	`t.Parallel()`
`29`	`29`
`30`	`30`	`// setup`
	`31`	`+`
	`32`	`+// Requires postgres because retry business logic is required, and this is only implemented in the database.`
`31`	`33`	`if!dbtestutil.WillUsePostgres() {`
`32`	`34`	`t.Skip("This test requires postgres")`
`33`	`35`	`}`

Comments

(0)