Commitcdd6734

committed

Fix flaky label evaluation by sorting both sides

Signed-off-by: Danny Kopping <danny@coder.com>

1 parentc11dc61 commitcdd6734Copy full SHA for cdd6734

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -206,9 +206,11 @@ func verifyCollectedMetrics(t testing.T, expected []agentproto.Stats_Metric, a`
`206`	`206`
`207`	`207`	`dtoLabels:=asMetricAgentLabels(d.GetLabel())`
`208`	`208`	`// dto labels are sorted in alphabetical order.`
`209`		`-sort.Slice(e.Labels,func(i,jint)bool {`
	`209`	`+sortFn:=func(i,jint)bool {`
`210`	`210`	`returne.Labels[i].Name<e.Labels[j].Name`
`211`		`-})`
	`211`	`+}`
	`212`	`+sort.Slice(e.Labels,sortFn)`
	`213`	`+sort.Slice(dtoLabels,sortFn)`
`212`	`214`	`require.Equal(t,e.Labels,dtoLabels,d.String())`
`213`	`215`	`}`
`214`	`216`	`returntrue`

Comments

(0)