Commitccf294e

authored

chore: improve visuals of dynamic parameters (#18537)

1 parente5eb2a8 commitccf294eCopy full SHA for ccf294e

File tree

-9

lines changed

-9

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ const ParameterLabel: FC<ParameterLabelProps> = ({`
`139`	`139`	`htmlFor={id}`
`140`	`140`	`className="flex gap-2 flex-wrap text-sm font-medium"`
`141`	`141`	`>`
`142`		`-<spanclassName="flex">`
	`142`	`+<spanclassName="flex font-semibold">`
`143`	`143`	`{displayName}`
`144`	`144`	`{parameter.required&&(`
`145`	`145`	`<spanclassName="text-content-destructive">*</span>`
`@@ -175,7 +175,8 @@ const ParameterLabel: FC<ParameterLabelProps> = ({`
`175`	`175`	`</span>`
`176`	`176`	`</TooltipTrigger>`
`177`	`177`	`<TooltipContentclassName="max-w-xs">`
`178`		`-This parameter only applies for a single workspace start`
	`178`	`+This parameter is ephemeral and will reset to the template`
	`179`	`+default on workspace restart.`
`179`	`180`	`</TooltipContent>`
`180`	`181`	`</Tooltip>`
`181`	`182`	`</TooltipProvider>`
`@@ -209,7 +210,7 @@ const ParameterLabel: FC<ParameterLabelProps> = ({`
`209`	`210`	`</span>`
`210`	`211`	`</TooltipTrigger>`
`211`	`212`	`<TooltipContentclassName="max-w-xs">`
`212`		`-Autofilled from the URL`
	`213`	`+Autofilled from the URL.`
`213`	`214`	`</TooltipContent>`
`214`	`215`	`</Tooltip>`
`215`	`216`	`</TooltipProvider>`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -114,12 +114,10 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({`
`114`	`114`
`115`	`115`	`return(`
`116`	`116`	`<divclassName="flex flex-col gap-4 p-5">`
`117`		`-<h1className="text-xl m-0 text-content-primary font-semibold leading-none ">`
`118`		`-Ephemeral Parameters`
`119`		`-</h1>`
`120`	`117`	`<pclassName="m-0 text-sm text-content-secondary">`
`121`		`-This template has ephemeral parameters that must be configured on the`
`122`		`-workspace parameters page`
	`118`	`+This workspace has ephemeral parameters which may use a temporary`
	`119`	`+value on workspace start. Configure the following parameters in`
	`120`	`+workspace settings.`
`123`	`121`	`</p>`
`124`	`122`
`125`	`123`	`<div>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ export const WorkspaceParametersPageViewExperimental: FC<`
`194`	`194`	`{(templateVersionId\|\|workspace.latest_build.template_version_id)&&(`
`195`	`195`	`<divclassName="flex flex-col gap-2">`
`196`	`196`	`<LabelclassName="text-sm text-content-secondary">Version ID</Label>`
`197`		`-<pclassName="m-0 text-sm font-medium">`
	`197`	`+<pclassName="m-0 text-xs font-medium font-mono">`
`198`	`198`	`{templateVersionId??workspace.latest_build.template_version_id}`
`199`	`199`	`</p>`
`200`	`200`	`</div>`

Comments

(0)