Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitcc3f2de

Browse files
committed
return timings in coder_workspace_exec
1 parentaa33071 commitcc3f2de

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

‎mcp/tools/tools_coder.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"errors"
88
"io"
99
"strings"
10+
"time"
1011

1112
"github.com/google/uuid"
1213
"github.com/mark3labs/mcp-go/mcp"
@@ -217,6 +218,7 @@ func handleCoderWorkspaceExec(deps ToolDeps) mcpserver.ToolHandlerFunc {
217218
returnnil,xerrors.Errorf("no connected agents for workspace %s",ws.ID)
218219
}
219220

221+
startedAt:=time.Now()
220222
conn,err:=workspacesdk.New(deps.Client).AgentReconnectingPTY(ctx, workspacesdk.WorkspaceAgentReconnectingPTYOpts{
221223
AgentID:agt.ID,
222224
Reconnect:uuid.New(),
@@ -229,6 +231,7 @@ func handleCoderWorkspaceExec(deps ToolDeps) mcpserver.ToolHandlerFunc {
229231
returnnil,xerrors.Errorf("failed to open reconnecting PTY: %w",err)
230232
}
231233
deferconn.Close()
234+
connectedAt:=time.Now()
232235

233236
varbuf bytes.Buffer
234237
if_,err:=io.Copy(&buf,conn);err!=nil {
@@ -238,10 +241,23 @@ func handleCoderWorkspaceExec(deps ToolDeps) mcpserver.ToolHandlerFunc {
238241
returnnil,xerrors.Errorf("failed to read from reconnecting PTY: %w",err)
239242
}
240243
}
244+
completedAt:=time.Now()
245+
connectionTime:=connectedAt.Sub(startedAt)
246+
executionTime:=completedAt.Sub(connectedAt)
247+
248+
resp:=map[string]string{
249+
"connection_time":connectionTime.String(),
250+
"execution_time":executionTime.String(),
251+
"output":buf.String(),
252+
}
253+
respJSON,err:=json.Marshal(resp)
254+
iferr!=nil {
255+
returnnil,xerrors.Errorf("failed to encode workspace build: %w",err)
256+
}
241257

242258
return&mcp.CallToolResult{
243259
Content: []mcp.Content{
244-
mcp.NewTextContent(strings.TrimSpace(buf.String())),
260+
mcp.NewTextContent(string(respJSON)),
245261
},
246262
},nil
247263
}

‎mcp/tools/tools_coder_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,8 @@ func TestCoderTools(t *testing.T) {
190190
_=pty.ReadLine(ctx)// skip the echo
191191

192192
// Then: the response is the output of the command.
193-
expected:=makeJSONRPCTextResponse(t,randString)
194193
actual:=pty.ReadLine(ctx)
195-
testutil.RequireJSONEq(t,expected,actual)
194+
require.Contains(t,actual,randString)
196195
})
197196

198197
// NOTE: this test runs after the list_workspaces tool is called.

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp