- Notifications
You must be signed in to change notification settings - Fork1k
Commitc517aab
Rafael Rodriguez
fix: add heartbeat to keep dynamic params websocket open (#20026)
## SummaryIn this pull request we're adding a heartbeat to the`handleParameterWebsocket` function to ensure that the connection staysopen until the 30 min timeout has been reached.Closes:#19805### Testing- Reproduced the problem mentioned in the issue (websocket connectioncloses after ~10 minutes of inactivity on the create workspace page)<img width="1870" height="357" alt="Screenshot 2025-09-26 at 15 58 51"src="https://github.com/user-attachments/assets/a9e2e89e-87c5-4afa-9644-afe246a15f79"/>- Confirmed that adding the heartbeat kept the connection open until the30 min timeout was reached<img width="1636" height="387" alt="Screenshot 2025-09-29 at 15 51 43"src="https://github.com/user-attachments/assets/0a8c5cda-29a6-493d-a6c0-4a2629da8838"/>1 parent1f71c2c commitc517aab
1 file changed
+2
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
142 | 144 | | |
143 | 145 | | |
144 | 146 | | |
| |||
0 commit comments
Comments
(0)