NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

Commitc31768d

authored

fix: use filepath to construct mcp test write path (#19808)

Hopefullyfixescoder/internal#993``` file path must be absolute: "/test/some/path"```Not sure if this is the right fix though, since I am not sure how thisonly flakes rather than always failing. It looks like starting with `/`should not be considered absolute in Windows, but then how did it everpass at all?

1 parent18b0aca commitc31768dCopy full SHA for c31768d

File tree

1 file changed

-2

lines changed

codersdk/toolsdk
- toolsdk_test.go

1 file changed

-2

lines changed

`‎codersdk/toolsdk/toolsdk_test.go‎`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -615,14 +615,17 @@ func TestTools(t *testing.T) {`
`615`	`615`	`tb,err:=toolsdk.NewDeps(client)`
`616`	`616`	`require.NoError(t,err)`
`617`	`617`
	`618`	`+tmpdir:=os.TempDir()`
	`619`	`+filePath:=filepath.Join(tmpdir,"write")`
	`620`	`+`
`618`	`621`	`_,err=testTool(t,toolsdk.WorkspaceWriteFile,tb, toolsdk.WorkspaceWriteFileArgs{`
`619`	`622`	`Workspace:workspace.Name,`
`620`		`-Path:"/test/some/path",`
	`623`	`+Path:filePath,`
`621`	`624`	`Content: []byte("content"),`
`622`	`625`	`})`
`623`	`626`	`require.NoError(t,err)`
`624`	`627`
`625`		`-b,err:=afero.ReadFile(fs,"/test/some/path")`
	`628`	`+b,err:=afero.ReadFile(fs,filePath)`
`626`	`629`	`require.NoError(t,err)`
`627`	`630`	`require.Equal(t, []byte("content"),b)`
`628`	`631`	`})`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc31768d

File tree

1 file changed

1 file changed

`‎codersdk/toolsdk/toolsdk_test.go‎`

0 commit comments