Commitc230bcf

authored

fix: previous parameter value is not a number (#12246)

1 parentb4fb754 commitc230bcfCopy full SHA for c230bcf

File tree

+21

-1

lines changed

+21

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ func validateBuildParameter(richParameter TemplateVersionParameter, buildParamet`
`60`	`60`	`value=richParameter.DefaultValue`
`61`	`61`	`}`
`62`	`62`
`63`		`-iflastBuildParameter!=nil&&richParameter.Type=="number"&&len(richParameter.ValidationMonotonic)>0 {`
	`63`	`+iflastBuildParameter!=nil&&lastBuildParameter.Value!=""&&richParameter.Type=="number"&&len(richParameter.ValidationMonotonic)>0 {`
`64`	`64`	`prev,err:=strconv.Atoi(lastBuildParameter.Value)`
`65`	`65`	`iferr!=nil {`
`66`	`66`	`returnxerrors.Errorf("previous parameter value is not a number: %s",lastBuildParameter.Value)`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -309,6 +309,26 @@ func TestRichParameterValidation(t *testing.T) {`
`309`	`309`	`})`
`310`	`310`	`}`
`311`	`311`
	`312`	`+funcTestParameterResolver_ValidateResolve_EmptyString_Monotonic(t*testing.T) {`
	`313`	`+t.Parallel()`
	`314`	`+uut:= codersdk.ParameterResolver{`
	`315`	`+Rich: []codersdk.WorkspaceBuildParameter{{Name:"n",Value:""}},`
	`316`	`+}`
	`317`	`+p:= codersdk.TemplateVersionParameter{`
	`318`	`+Name:"n",`
	`319`	`+Type:"number",`
	`320`	`+Mutable:true,`
	`321`	`+DefaultValue:"0",`
	`322`	`+ValidationMonotonic:codersdk.MonotonicOrderIncreasing,`
	`323`	`+}`
	`324`	`+v,err:=uut.ValidateResolve(p,&codersdk.WorkspaceBuildParameter{`
	`325`	`+Name:"n",`
	`326`	`+Value:"1",`
	`327`	`+})`
	`328`	`+require.NoError(t,err)`
	`329`	`+require.Equal(t,"1",v)`
	`330`	`+}`
	`331`	`+`
`312`	`332`	`funcTestParameterResolver_ValidateResolve_Ephemeral_OverridePrevious(t*testing.T) {`
`313`	`333`	`t.Parallel()`
`314`	`334`	`uut:= codersdk.ParameterResolver{`

Comments

(0)