NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

Commitc1a3010

committed

Optimize AcquireNotificationMessages to drop a join

This has the unfortunate side-effect of not allowing the AcquireNotificationMessagesRow.Payload type to be overriden to []byte as it was previously, but it does not change the semanticsSigned-off-by: Danny Kopping <danny@coder.com>

1 parent703559c commitc1a3010Copy full SHA for c1a3010

File tree

2 files changed

-7

lines changed

coderd/database
- queries
  - notifications.sql
- queries.sql.go

2 files changed

-7

lines changed

`‎coderd/database/queries.sql.go`

Lines changed: 3 additions & 4 deletions

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

`‎coderd/database/queries/notifications.sql`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ WITH acquired AS (`
`72`	`72`	`FORUPDATE OF nm`
`73`	`73`	`SKIP LOCKED`
`74`	`74`	`LIMITsqlc.arg('count'))`
`75`		`- RETURNINGid)`
	`75`	`+ RETURNING*)`
`76`	`76`	`SELECT`
`77`	`77`	`-- message`
`78`	`78`	`nm.id,`
`@@ -82,8 +82,7 @@ SELECT`
`82`	`82`	`-- template`
`83`	`83`	`nt.title_template,`
`84`	`84`	`nt.body_template`
`85`		`-FROM acquired`
`86`		`-JOIN notification_messages nmONacquired.id=nm.id`
	`85`	`+FROM acquired nm`
`87`	`86`	`JOIN notification_templates ntONnm.notification_template_id=nt.id;`
`88`	`87`
`89`	`88`	`-- name: BulkMarkNotificationMessagesFailed :execrows`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc1a3010

File tree

2 files changed

2 files changed

`‎coderd/database/queries.sql.go`

`‎coderd/database/queries/notifications.sql`

0 commit comments