Commitbfd392b

authored

fix: use int64 in publisher delay (#19457)

1 parentbaf3067 commitbfd392bCopy full SHA for bfd392b

File tree

+29

-2

lines changed

+29

-2

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,12 @@ func Int63() (int64, error) {`
`47`	`47`	`returnrng.Int63(),cs.err`
`48`	`48`	`}`
`49`	`49`
	`50`	`+// Int63n returns a non-negative integer in [0,maxVal) as an int64.`
	`51`	`+funcInt63n(maxValint64) (int64,error) {`
	`52`	`+rng,cs:=secureRand()`
	`53`	`+returnrng.Int63n(maxVal),cs.err`
	`54`	`+}`
	`55`	`+`
`50`	`56`	`// Intn returns a non-negative integer in [0,maxVal) as an int.`
`51`	`57`	`funcIntn(maxValint) (int,error) {`
`52`	`58`	`rng,cs:=secureRand()`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,27 @@ func TestInt63(t *testing.T) {`
`19`	`19`	`}`
`20`	`20`	`}`
`21`	`21`
	`22`	`+funcTestInt63n(t*testing.T) {`
	`23`	`+t.Parallel()`
	`24`	`+`
	`25`	`+fori:=0;i<20;i++ {`
	`26`	`+v,err:=cryptorand.Int63n(100)`
	`27`	`+require.NoError(t,err,"unexpected error from Int63n")`
	`28`	`+t.Logf("value: %v <- random?",v)`
	`29`	`+require.GreaterOrEqual(t,v,int64(0),"values must be positive")`
	`30`	`+require.Less(t,v,int64(100),"values must be less than 100")`
	`31`	`+}`
	`32`	`+`
	`33`	`+// Ensure Int63n works for int larger than 32 bits`
	`34`	`+_,err:=cryptorand.Int63n(1<<35)`
	`35`	`+require.NoError(t,err,"expected Int63n to work for 64-bit int")`
	`36`	`+`
	`37`	`+// Expect a panic if max is negative`
	`38`	`+require.PanicsWithValue(t,"invalid argument to Int63n",func() {`
	`39`	`+cryptorand.Int63n(0)`
	`40`	`+})`
	`41`	`+}`
	`42`	`+`
`22`	`43`	`funcTestIntn(t*testing.T) {`
`23`	`44`	`t.Parallel()`
`24`	`45`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,8 @@ func (p *tallymanPublisher) Start() error {`
`136`	`136`	`ifp.initialDelay<=0 {`
`137`	`137`	`// Pick a random time between tallymanPublishInitialMinimumDelay and`
`138`	`138`	`// tallymanPublishInterval.`
`139`		`-maxPlusDelay:=int(tallymanPublishInterval-tallymanPublishInitialMinimumDelay)`
`140`		`-plusDelay,err:=cryptorand.Intn(maxPlusDelay)`
	`139`	`+maxPlusDelay:=tallymanPublishInterval-tallymanPublishInitialMinimumDelay`
	`140`	`+plusDelay,err:=cryptorand.Int63n(int64(maxPlusDelay))`
`141`	`141`	`iferr!=nil {`
`142`	`142`	`returnxerrors.Errorf("could not generate random start delay: %w",err)`
`143`	`143`	`}`

Comments

(0)