NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.6k

Commitbb69054

authored

fix(cli): remove loading indicator when pinging with verbose logs (#16305)

This was causing some verbose log lines to be prepended with the spinnermessage, e.g.```◱ Collecting diagnostics...2025-01-28 10:26:27.502```which doesnt look very good. Presumably anyone running it with verbose will know it takes a moment to collect diagnostics first.

1 parentb44ae40 commitbb69054Copy full SHA for bb69054

File tree

1 file changed

-1

lines changed

cli
- ping.go

1 file changed

-1

lines changed

`‎cli/ping.go‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,9 @@ func (r RootCmd) ping() serpent.Command {`
`120`	`120`	`spin:=spinner.New(spinner.CharSets[5],100*time.Millisecond)`
`121`	`121`	`spin.Writer=inv.Stderr`
`122`	`122`	`spin.Suffix=pretty.Sprint(cliui.DefaultStyles.Keyword," Collecting diagnostics...")`
`123`		`-spin.Start()`
	`123`	`+if!r.verbose {`
	`124`	`+spin.Start()`
	`125`	`+}`
`124`	`126`
`125`	`127`	`opts:=&workspacesdk.DialAgentOptions{}`
`126`	`128`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbb69054

File tree

1 file changed

1 file changed

`‎cli/ping.go‎`

0 commit comments