NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

Commitbae12e1

authored

fix: remove backtick from valid password characters (#15756)

Since backticks are the PowerShell escape character, they are silentlyconsumed. To actually use backticks, they would need to be doubled whenused.This change increases the safety of generated passwords for otherterraform modules that might use this value unawares.

1 parent40624bf commitbae12e1Copy full SHA for bae12e1

File tree

1 file changed

-3

lines changed

examples/templates/azure-windows
- main.tf

1 file changed

-3

lines changed

`‎examples/templates/azure-windows/main.tf‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,9 +65,9 @@ resource "random_password" "admin_password" {`
`65`	`65`	`length=16`
`66`	`66`	`special=true`
`67`	`67`	`# https://docs.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/password-must-meet-complexity-requirements#reference`
`68`		`-# we remove characters that require special handling in XML, as this is how we pass it to the VM`
`69`		`-# namely: <>&'"`
`70`		-override_special="~!@#$%^*_-+=`\|\\(){}[]:;,.?/"
	`68`	`+# we remove characters that require special handling in XML, as this is how we pass it to the VM; we also remove the powershell escape character`
	`69`	+# namely: <>&'`"
	`70`	`+override_special="~!@#$%^*_-+=\|\\(){}[]:;,.?/"`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`locals {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbae12e1

File tree

1 file changed

1 file changed

`‎examples/templates/azure-windows/main.tf‎`

0 commit comments