Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitba0bcf0

Browse files
committed
Review & linter feedback
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
1 parentbb479c2 commitba0bcf0

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

‎enterprise/coderd/prebuilds/metricscollector.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ func (*MetricsCollector) Describe(descCh chan<- *prometheus.Desc) {
7979
}
8080

8181
func (mc*MetricsCollector)Collect(metricsChchan<- prometheus.Metric) {
82+
// nolint:gocritic // We need to set an authz context to read metrics from the db.
8283
ctx,cancel:=context.WithTimeout(dbauthz.AsPrebuildsOrchestrator(context.Background()),10*time.Second)
8384
defercancel()
84-
// nolint:gocritic // just until we get back to this
8585
prebuildMetrics,err:=mc.database.GetPrebuildMetrics(ctx)
8686
iferr!=nil {
8787
mc.logger.Error(ctx,"failed to get prebuild metrics",slog.Error(err))

‎enterprise/coderd/prebuilds/reconcile_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1012,6 +1012,7 @@ func setupTestDBWorkspace(
10121012
returnworkspace
10131013
}
10141014

1015+
// nolint:revive // It's a control flag, but this is a test.
10151016
funcsetupTestDBWorkspaceAgent(t*testing.T,db database.Store,workspaceID uuid.UUID,eligiblebool) database.WorkspaceAgent {
10161017
build,err:=db.GetLatestWorkspaceBuildByWorkspaceID(t.Context(),workspaceID)
10171018
require.NoError(t,err)

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp