You signed in with another tab or window.Reload to refresh your session.You signed out in another tab or window.Reload to refresh your session.You switched accounts on another tab or window.Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/about/contributing/CONTRIBUTING.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -154,7 +154,7 @@ We welcome pull requests (PRs) from community members including (but not limited
154
154
155
155
We will ask that you sign a Contributor License Agreement before we accept any contributions into our repo.
156
156
157
-
Please keep PRs small and selfcontained. This allows code reviewers (see below) to focus and fully understand the PR. A good rule of thumb is less than 1000 lines changed. (One exception is a mechanistic refactor, like renaming, that is conceptually trivial but might have a large line count.)
157
+
Please keep PRs small and self-contained. This allows code reviewers (see below) to focus and fully understand the PR. A good rule of thumb is less than 1000 lines changed. (One exception is a mechanistic refactor, like renaming, that is conceptually trivial but might have a large line count.)
158
158
159
159
If your intended feature or refactor will be larger than this:
160
160
@@ -167,7 +167,7 @@ Stacking tools like [Graphite](https://www.graphite.dev) are useful for keeping
167
167
Each PR:
168
168
169
169
- Must individually build and pass all tests, including formatting and linting.
170
-
- Must not introduce regressions orbackcompatibility issues, evenif alater PR would resolve the issue.
170
+
- Must not introduce regressions orbackward-compatibility issues, evenif asubsequent PRin your series would resolve the issue.
171
171
- Should be a conceptually coherent change set.
172
172
173
173
In practice, many of these smaller PRs will be invisible to end users, and that is ok. For example, you might introduce