NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.8k

Commitb7cd545

authored

test: fix TestConfigSSH_FileWriteAndOptionsFlow on Windows 11 24H2 (#17410)

Fixes tests on Windows 11 due to `printf` not being a recognized command name.

1 parent8cc743a commitb7cd545Copy full SHA for b7cd545

File tree

1 file changed

-8

lines changed

cli
- configssh_test.go

1 file changed

-8

lines changed

`‎cli/configssh_test.go‎`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) {`
`435`	`435`	`"# :hostname-suffix=coder-suffix",`
`436`	`436`	`"# :header=X-Test-Header=foo",`
`437`	`437`	`"# :header=X-Test-Header2=bar",`
`438`		`-"# :header-command=printf h1=v1 h2=\"v2\" h3='v3'",`
	`438`	`+"# :header-command=echo h1=v1 h2=\"v2\" h3='v3'",`
`439`	`439`	`"#",`
`440`	`440`	`},"\n"),`
`441`	`441`	`strings.Join([]string{`
`@@ -451,7 +451,7 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) {`
`451`	`451`	`"--hostname-suffix","coder-suffix",`
`452`	`452`	`"--header","X-Test-Header=foo",`
`453`	`453`	`"--header","X-Test-Header2=bar",`
`454`		`-"--header-command","printf h1=v1 h2=\"v2\" h3='v3'",`
	`454`	`+"--header-command","echo h1=v1 h2=\"v2\" h3='v3'",`
`455`	`455`	`},`
`456`	`456`	`},`
`457`	`457`	`{`
`@@ -566,36 +566,36 @@ func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) {`
`566`	`566`	`name:"Header command",`
`567`	`567`	`args: []string{`
`568`	`568`	`"--yes",`
`569`		`-"--header-command","printf h1=v1",`
	`569`	`+"--header-command","echo h1=v1",`
`570`	`570`	`},`
`571`	`571`	`wantErr:false,`
`572`	`572`	`hasAgent:true,`
`573`	`573`	`wantConfig:wantConfig{`
`574`		-regexMatch:`ProxyCommand .* --header-command "printf h1=v1" ssh .* --ssh-host-prefix coder. %h`,
	`574`	+regexMatch:`ProxyCommand .* --header-command "echo h1=v1" ssh .* --ssh-host-prefix coder. %h`,
`575`	`575`	`},`
`576`	`576`	`},`
`577`	`577`	`{`
`578`	`578`	`name:"Header command with double quotes",`
`579`	`579`	`args: []string{`
`580`	`580`	`"--yes",`
`581`		`-"--header-command","printf h1=v1 h2=\"v2\"",`
	`581`	`+"--header-command","echo h1=v1 h2=\"v2\"",`
`582`	`582`	`},`
`583`	`583`	`wantErr:false,`
`584`	`584`	`hasAgent:true,`
`585`	`585`	`wantConfig:wantConfig{`
`586`		-regexMatch:`ProxyCommand .* --header-command "printf h1=v1 h2=\\\"v2\\\"" ssh .* --ssh-host-prefix coder. %h`,
	`586`	+regexMatch:`ProxyCommand .* --header-command "echo h1=v1 h2=\\\"v2\\\"" ssh .* --ssh-host-prefix coder. %h`,
`587`	`587`	`},`
`588`	`588`	`},`
`589`	`589`	`{`
`590`	`590`	`name:"Header command with single quotes",`
`591`	`591`	`args: []string{`
`592`	`592`	`"--yes",`
`593`		`-"--header-command","printf h1=v1 h2='v2'",`
	`593`	`+"--header-command","echo h1=v1 h2='v2'",`
`594`	`594`	`},`
`595`	`595`	`wantErr:false,`
`596`	`596`	`hasAgent:true,`
`597`	`597`	`wantConfig:wantConfig{`
`598`		-regexMatch:`ProxyCommand .* --header-command "printf h1=v1 h2='v2'" ssh .* --ssh-host-prefix coder. %h`,
	`598`	+regexMatch:`ProxyCommand .* --header-command "echo h1=v1 h2='v2'" ssh .* --ssh-host-prefix coder. %h`,
`599`	`599`	`},`
`600`	`600`	`},`
`601`	`601`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb7cd545

File tree

1 file changed

1 file changed

`‎cli/configssh_test.go‎`

0 commit comments