Commitb77b543

authored

test(coderd/database/pubsub): ensure db closure on unhappy paths (#16327)

1 parentc069563 commitb77b543Copy full SHA for b77b543

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -305,6 +305,9 @@ func TestMeasureLatency(t *testing.T) {`
`305`	`305`	`require.NoError(t,err)`
`306`	`306`	`db,err:=sql.Open("postgres",connectionURL)`
`307`	`307`	`require.NoError(t,err)`
	`308`	`+t.Cleanup(func() {`
	`309`	`+_=db.Close()`
	`310`	`+})`
`308`	`311`	`ps,err:=pubsub.New(ctx,logger,db,connectionURL)`
`309`	`312`	`require.NoError(t,err)`
`310`	`313`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,7 @@ func TestPGPubsubDriver(t *testing.T) {`
`137`	`137`	`// use a separate subber and pubber so we can keep track of listener connections`
`138`	`138`	`db,err:=sql.Open("postgres",connectionURL)`
`139`	`139`	`require.NoError(t,err)`
	`140`	`+deferdb.Close()`
`140`	`141`	`pubber,err:=pubsub.New(ctx,logger,db,connectionURL)`
`141`	`142`	`require.NoError(t,err)`
`142`	`143`	`deferpubber.Close()`
`@@ -147,6 +148,7 @@ func TestPGPubsubDriver(t *testing.T) {`
`147`	`148`	`tconn,err:=subDriver.Connector(connectionURL)`
`148`	`149`	`require.NoError(t,err)`
`149`	`150`	`tcdb:=sql.OpenDB(tconn)`
	`151`	`+defertcdb.Close()`
`150`	`152`	`subber,err:=pubsub.New(ctx,logger,tcdb,connectionURL)`
`151`	`153`	`require.NoError(t,err)`
`152`	`154`	`defersubber.Close()`

Comments

(0)