Commitb55a7a8

Emyrk

and

aslilac

authored

chore: delete user codersdk to support status code regression (#14173)

* chore: delete user codersdk to support status code regression* Update codersdk/users.goCo-authored-by: Kayla Washburn-Love <mckayla@hey.com>---------Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>

1 parent8c05651 commitb55a7a8Copy full SHA for b55a7a8

File tree

1 file changed

-1

lines changed

codersdk
- users.go

1 file changed

-1

lines changed

`‎codersdk/users.go`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,9 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {`
`309`	`309`	`returnerr`
`310`	`310`	`}`
`311`	`311`	`deferres.Body.Close()`
`312`		`-ifres.StatusCode!=http.StatusOK {`
	`312`	`+// Check for a 200 or a 204 response. 2.14.0 accidentally included a 204 response,`
	`313`	`+// which was a breaking change, and reverted in 2.14.1.`
	`314`	`+ifres.StatusCode!=http.StatusOK&&res.StatusCode!=http.StatusNoContent {`
`313`	`315`	`returnReadBodyAsError(res)`
`314`	`316`	`}`
`315`	`317`	`returnnil`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb55a7a8

File tree

1 file changed

1 file changed

`‎codersdk/users.go`

0 commit comments