Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitb4e4173

Browse files
authored
test: improve workspace build job completion logging (#19740)
Closescoder/internal#935This PR enhances the AwaitWorkspaceBuildJobCompleted func in coderdtestpkg to provide better visibility into test failures and debugginginformation.
1 parent1677a30 commitb4e4173

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

‎coderd/coderdtest/coderdtest.go‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,9 +1097,17 @@ func AwaitWorkspaceBuildJobCompleted(t testing.TB, client *codersdk.Client, buil
10971097
require.Eventually(t,func()bool {
10981098
varerrerror
10991099
workspaceBuild,err=client.WorkspaceBuild(ctx,build)
1100-
returnassert.NoError(t,err)&&workspaceBuild.Job.CompletedAt!=nil
1100+
iferr!=nil {
1101+
t.Logf("failed to get workspace build %s: %v",build,err)
1102+
returnfalse
1103+
}
1104+
ifworkspaceBuild.Job.CompletedAt==nil {
1105+
t.Logf("workspace build job %s still running (status: %s)",build,workspaceBuild.Job.Status)
1106+
returnfalse
1107+
}
1108+
returntrue
11011109
},testutil.WaitMedium,testutil.IntervalMedium)
1102-
t.Logf("got workspace build job %s",build)
1110+
t.Logf("got workspace build job %s (status: %s)",build,workspaceBuild.Job.Status)
11031111
returnworkspaceBuild
11041112
}
11051113

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp