Commitb4c29f3

authored

fix: Always use UTC time when inserting stats (#4009)

Fixes a flake reported by@mafredri

1 parentd0b02e5 commitb4c29f3Copy full SHA for b4c29f3

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -665,6 +665,6 @@ func TestTemplateDAUs(t *testing.T) {`
`665`	`665`	`workspaces,err=client.Workspaces(ctx, codersdk.WorkspaceFilter{})`
`666`	`666`	`require.NoError(t,err)`
`667`	`667`	`assert.WithinDuration(t,`
`668`		`-time.Now(),workspaces[0].LastUsedAt,time.Minute,`
	`668`	`+database.Now(),workspaces[0].LastUsedAt,time.Minute,`
`669`	`669`	`)`
`670`	`670`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -848,7 +848,7 @@ func (api API) workspaceAgentReportStats(rw http.ResponseWriter, r http.Reques`
`848`	`848`
`849`	`849`	`_,err=api.Database.InsertAgentStat(ctx, database.InsertAgentStatParams{`
`850`	`850`	`ID:uuid.New(),`
`851`		`-CreatedAt:time.Now(),`
	`851`	`+CreatedAt:database.Now(),`
`852`	`852`	`AgentID:workspaceAgent.ID,`
`853`	`853`	`WorkspaceID:build.WorkspaceID,`
`854`	`854`	`UserID:workspace.OwnerID,`
`@@ -865,7 +865,7 @@ func (api API) workspaceAgentReportStats(rw http.ResponseWriter, r http.Reques`
`865`	`865`
`866`	`866`	`err=api.Database.UpdateWorkspaceLastUsedAt(ctx, database.UpdateWorkspaceLastUsedAtParams{`
`867`	`867`	`ID:build.WorkspaceID,`
`868`		`-LastUsedAt:time.Now(),`
	`868`	`+LastUsedAt:database.Now(),`
`869`	`869`	`})`
`870`	`870`	`iferr!=nil {`
`871`	`871`	`httpapi.Write(rw,http.StatusBadRequest, codersdk.Response{`

Comments

(0)