Commitb3a3671

authored

fix: use static port number for prometheus test (#14000)

1 parentdac14fe commitb3a3671Copy full SHA for b3a3671

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -301,11 +301,11 @@ func TestProvisionerDaemon_SessionToken(t *testing.T) {`
`301`	`301`	`})`
`302`	`302`	`}`
`303`	`303`
`304`		-//nolint:paralleltest,tparallel //Prometheus endpoint tends to fail with `bind: address already in use`.
	`304`	`+//nolint:paralleltest,tparallel //Test uses a static port.`
`305`	`305`	`funcTestProvisionerDaemon_PrometheusEnabled(t*testing.T) {`
`306`		`-t.Skip("Flaky test - see https://github.com/coder/coder/issues/13931")`
`307`		`-`
`308`		`-prometheusPort:=testutil.RandomPortNoListen(t)`
	`306`	+// Ephemeral ports have a tendency to conflict and fail with `bind: address already in use` error.
	`307`	`+// This workaround forces a static port for Prometheus that hopefully won't be used by other tests.`
	`308`	`+prometheusPort:=32001`
`309`	`309`
`310`	`310`	`// Configure CLI client`
`311`	`311`	`client,admin:=coderdenttest.New(t,&coderdenttest.Options{`

Comments

(0)