Commitb1aff3f

committed

Collect all todo testcases in a single file

1 parent0f53056 commitb1aff3fCopy full SHA for b1aff3f

File tree

-9

lines changed

-9

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,14 @@ import (`
`15`	`15`	`)`
`16`	`16`
`17`	`17`	`funcTestTemplateVersionPresets(t*testing.T) {`
	`18`	`+// TODO (sasswart): test case: what if immutable parameters are used in the preset?`
	`19`	`+// TODO (sasswart): test case: what if presets are defined for a template version with no params?`
	`20`	`+// TODO (sasswart): test case: what if a non active version is selected?`
	`21`	`+// TODO (sasswart): test case: what if a preset is selected that has no parameters?`
	`22`	`+// TODO (sasswart): what if we have preset params and autofill params on the same param?`
	`23`	`+// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?`
	`24`	`+// If so, how should it behave? Reset to initial value? reset to last set value?`
	`25`	`+// TODO (sasswart): test case: rich parameters`
`18`	`26`	`// TODO (sasswart): Test case: what if a user tries to read presets or preset parameters from a different org?`
`19`	`27`
`20`	`28`	`t.Parallel()`

Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -164,15 +164,6 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({`
`164`	`164`	`);`
`165`	`165`
`166`	`166`	`useEffect(()=>{`
`167`		`-// TODO (sasswart): test case: what if immutable parameters are used in the preset?`
`168`		`-// TODO (sasswart): test case: what if presets are defined for a template version with no params?`
`169`		`-// TODO (sasswart): test case: what if a non active version is selected?`
`170`		`-// TODO (sasswart): test case: what if a preset is selected that has no parameters?`
`171`		`-// TODO (sasswart): what if we have preset params and autofill params on the same param?`
`172`		`-// TODO (sasswart): test case: if we move from preset to no preset, do we reset the params?`
`173`		`-// If so, how should it behave? Reset to initial value? reset to last set value?`
`174`		`-// TODO (sasswart): test case: rich parameters`
`175`		`-`
`176`	`167`	`constselectedPresetOption=presetOptions[selectedPresetIndex];`
`177`	`168`	`letselectedPreset:TypesGen.Preset\|undefined;`
`178`	`169`	`for(constpresetofpresets){`

Comments

(0)