Commitaff9e6c

committed

Review comments

Signed-off-by: Danny Kopping <danny@coder.com>

1 parentc6e75c2 commitaff9e6cCopy full SHA for aff9e6c

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ CREATE INDEX idx_notification_messages_status ON notification_messages (status);`
`52`	`52`	`-- TODO: autogenerate constants which reference the UUIDs`
`53`	`53`	`INSERT INTO notification_templates (id, name, title_template, body_template,"group", actions)`
`54`	`54`	`VALUES ('f517da0b-cdc9-410f-ab89-a86107c420ed','Workspace Deleted', E'Workspace "{{.Labels.name}}" deleted',`
`55`		`- E'Hi {{.UserName}}\n\nYour workspace {{.Labels.name}} was deleted.\nThe specified reason was "{{.Labels.reason}}{{ if .Labels.initiatedBy }} ({{ .Labels.initiatedBy }}){{end}}".',`
	`55`	`+ E'Hi {{.UserName}}\n\nYour workspace {{.Labels.name}} was deleted.\nThe specified reason was "{{.Labels.reason}}{{ if .Labels.initiator }} ({{ .Labels.initiator }}){{end}}".',`
`56`	`56`	`'Workspace Events','[`
`57`	`57`	`{`
`58`	`58`	`"label": "View workspaces",`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,8 @@ func (w *WebhookHandler) dispatch(msgPayload types.MessagePayload, title, body,`
`88`	`88`
`89`	`89`	`// Handle response.`
`90`	`90`	`ifresp.StatusCode/100>2 {`
`91`		`-// Body could be quite long here, let's grab the first500B and hope it contains useful debug info.`
`92`		`-respBody:=make([]byte,500)`
	`91`	`+// Body could be quite long here, let's grab the first512B and hope it contains useful debug info.`
	`92`	`+respBody:=make([]byte,512)`
`93`	`93`	`lr:=io.LimitReader(resp.Body,int64(len(respBody)))`
`94`	`94`	`n,err:=lr.Read(respBody)`
`95`	`95`	`iferr!=nil&&!errors.Is(err,io.EOF) {`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,8 @@ package notifications`
`2`	`2`
`3`	`3`	`import"github.com/google/uuid"`
`4`	`4`
`5`		`-// Workspaces.`
`6`		`-varTemplateWorkspaceDeleted=uuid.MustParse("f517da0b-cdc9-410f-ab89-a86107c420ed")// ...`
	`5`	`+// These vars are mapped to UUIDs in the notification_templates table.`
	`6`	`+// TODO: autogenerate these.`
	`7`	`+`
	`8`	`+// Workspace-related events.`
	`9`	`+varTemplateWorkspaceDeleted=uuid.MustParse("f517da0b-cdc9-410f-ab89-a86107c420ed")`

Comments

(0)