NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

Commitabb3df7

authored

fix(site): avoid constructing invalid apps url (#15711)

In Firefox, parsing a URL containing a `*` returns an error:```new URL("https://*--apps.sydney.fly.dev.coder.com") ``````Uncaught TypeError: URL constructor: https://*--apps.sydney.fly.dev.coder.com is not a valid URL. <anonymous> debugger eval code:1```In Chrome and Node, this same URL does not produce an error.This causes a workspace dashboard with apps to fail to load on Firefox.![image](https://github.com/user-attachments/assets/eeea4fe5-3759-432b-b7ce-22dfad5f8218)

1 parent3014713 commitabb3df7Copy full SHA for abb3df7

File tree

2 files changed

-4

lines changed

site/src/utils
- apps.ts
- portForward.ts

2 files changed

-4

lines changed

`‎site/src/utils/apps.ts‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,8 @@ export const createAppLinkHref = (`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`if(appsHost&&app.subdomain&&app.subdomain_name){`
`32`		-constbaseUrl=`${protocol}//${appsHost}`;
	`32`	+constbaseUrl=`${protocol}//${appsHost.replace("*",app.subdomain_name)}`;
`33`	`33`	`consturl=newURL(baseUrl);`
`34`		`-url.hostname=appsHost.replace("*",app.subdomain_name);`
`35`	`34`	`url.pathname="/";`
`36`	`35`
`37`	`36`	`href=url.toString();`

`‎site/src/utils/portForward.ts‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,8 @@ export const portForwardURL = (`
`13`	`13`
`14`	`14`	constsubdomain=`${port}${suffix}--${agentName}--${workspaceName}--${username}`;
`15`	`15`
`16`		-constbaseUrl=`${location.protocol}//${host}`;
	`16`	+constbaseUrl=`${location.protocol}//${host.replace("*",subdomain)}`;
`17`	`17`	`consturl=newURL(baseUrl);`
`18`		`-url.hostname=host.replace("*",subdomain);`
`19`	`18`
`20`	`19`	`returnurl.toString();`
`21`	`20`	`};`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitabb3df7

File tree

2 files changed

2 files changed

`‎site/src/utils/apps.ts‎`

`‎site/src/utils/portForward.ts‎`

0 commit comments