Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita827185

Browse files
refactor: move auto fill feature into an experiment (#12230)
1 parentc230bcf commita827185

File tree

6 files changed

+35
-18
lines changed

6 files changed

+35
-18
lines changed

‎coderd/apidoc/docs.go

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎coderd/apidoc/swagger.json

Lines changed: 7 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎codersdk/deployment.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2117,8 +2117,9 @@ type Experiment string
21172117

21182118
const (
21192119
// Add new experiments here!
2120-
ExperimentExampleExperiment="example"// This isn't used for anything.
2121-
ExperimentSharedPortsExperiment="shared-ports"
2120+
ExperimentExampleExperiment="example"// This isn't used for anything.
2121+
ExperimentSharedPortsExperiment="shared-ports"
2122+
ExperimentAutoFillParametersExperiment="auto-fill-parameters"// This should not be taken out of experiments until we have redesigned the feature.
21222123
)
21232124

21242125
// ExperimentsAll should include all experiments that are safe for

‎docs/api/schemas.md

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎site/src/api/typesGenerated.ts

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import { paramsUsedToCreateWorkspace } from "utils/workspace";
2626
import{CreateWorkspacePageView}from"./CreateWorkspacePageView";
2727
import{CreateWSPermissions,createWorkspaceChecks}from"./permissions";
2828
import{generateWorkspaceName}from"modules/workspaces/generateWorkspaceName";
29+
import{useDashboard}from"modules/dashboard/useDashboard";
2930

3031
exportconstcreateWorkspaceModes=["form","auto","duplicate"]asconst;
3132
exporttypeCreateWorkspaceMode=(typeofcreateWorkspaceModes)[number];
@@ -40,6 +41,7 @@ const CreateWorkspacePage: FC = () => {
4041
const[searchParams,setSearchParams]=useSearchParams();
4142
constmode=getWorkspaceMode(searchParams);
4243
constcustomVersionId=searchParams.get("version")??undefined;
44+
const{ experiments}=useDashboard();
4345

4446
constdefaultName=searchParams.get("name");
4547

@@ -51,12 +53,6 @@ const CreateWorkspacePage: FC = () => {
5153

5254
consttemplateQuery=useQuery(templateByName(organizationId,templateName));
5355

54-
constuserParametersQuery=useQuery({
55-
queryKey:["userParameters"],
56-
queryFn:()=>getUserParameters(templateQuery.data!.id),
57-
enabled:templateQuery.isSuccess,
58-
});
59-
6056
constpermissionsQuery=useQuery(
6157
checkAuthorization({
6258
checks:createWorkspaceChecks(organizationId),
@@ -97,6 +93,13 @@ const CreateWorkspacePage: FC = () => {
9793
[navigate],
9894
);
9995

96+
// Auto fill parameters
97+
constuserParametersQuery=useQuery({
98+
queryKey:["userParameters"],
99+
queryFn:()=>getUserParameters(templateQuery.data!.id),
100+
enabled:
101+
experiments.includes("auto-fill-parameters")&&templateQuery.isSuccess,
102+
});
100103
constautofillParameters=getAutofillParameters(
101104
searchParams,
102105
userParametersQuery.data ?userParametersQuery.data :[],

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp