|
5 | 5 | "bytes" |
6 | 6 | "encoding/hex" |
7 | 7 | "fmt" |
| 8 | +"io" |
8 | 9 | "net" |
9 | 10 | "os" |
10 | 11 | "path/filepath" |
@@ -127,3 +128,162 @@ func TestServer_X11(t *testing.T) { |
127 | 128 | _,err=fs.Stat(filepath.Join(home,".Xauthority")) |
128 | 129 | require.NoError(t,err) |
129 | 130 | } |
| 131 | + |
| 132 | +funcTestServer_X11_EvictionLRU(t*testing.T) { |
| 133 | +t.Parallel() |
| 134 | +ifruntime.GOOS!="linux" { |
| 135 | +t.Skip("X11 forwarding is only supported on Linux") |
| 136 | +} |
| 137 | + |
| 138 | +ctx:=testutil.Context(t,testutil.WaitLong) |
| 139 | +logger:=testutil.Logger(t) |
| 140 | +fs:=afero.NewMemMapFs() |
| 141 | + |
| 142 | +// Use in-process networking for X11 forwarding. |
| 143 | +inproc:=testutil.NewInProcNet() |
| 144 | + |
| 145 | +cfg:=&agentssh.Config{ |
| 146 | +X11Net:inproc, |
| 147 | +} |
| 148 | + |
| 149 | +s,err:=agentssh.NewServer(ctx,logger,prometheus.NewRegistry(),fs,agentexec.DefaultExecer,cfg) |
| 150 | +require.NoError(t,err) |
| 151 | +defers.Close() |
| 152 | +err=s.UpdateHostSigner(42) |
| 153 | +require.NoError(t,err) |
| 154 | + |
| 155 | +ln,err:=net.Listen("tcp","127.0.0.1:0") |
| 156 | +require.NoError(t,err) |
| 157 | + |
| 158 | +done:=testutil.Go(t,func() { |
| 159 | +err:=s.Serve(ln) |
| 160 | +assert.Error(t,err) |
| 161 | +}) |
| 162 | + |
| 163 | +c:=sshClient(t,ln.Addr().String()) |
| 164 | + |
| 165 | +// Calculate how many simultaneous X11 sessions we can create given the |
| 166 | +// configured port range. |
| 167 | +startPort:=agentssh.X11StartPort+agentssh.X11DefaultDisplayOffset |
| 168 | +maxSessions:=agentssh.X11MaxPort-startPort+1 |
| 169 | +require.Greater(t,maxSessions,0,"expected a positive maxSessions value") |
| 170 | + |
| 171 | +// shellSession holds references to the session and its standard streams so |
| 172 | +// that the test can keep them open (and optionally interact with them) for |
| 173 | +// the lifetime of the test. If we don't start the Shell with pipes in place, |
| 174 | +// the session will be torn down asynchronously during the test. |
| 175 | +typeshellSessionstruct { |
| 176 | +sess*gossh.Session |
| 177 | +stdin io.WriteCloser |
| 178 | +stdout io.Reader |
| 179 | +stderr io.Reader |
| 180 | +// scanner is used to read the output of the session, line by line. |
| 181 | +scanner*bufio.Scanner |
| 182 | +} |
| 183 | + |
| 184 | +sessions:=make([]shellSession,0,maxSessions) |
| 185 | +fori:=0;i<maxSessions;i++ { |
| 186 | +sess,err:=c.NewSession() |
| 187 | +require.NoError(t,err) |
| 188 | + |
| 189 | +_,err=sess.SendRequest("x11-req",true,gossh.Marshal(ssh.X11{ |
| 190 | +AuthProtocol:"MIT-MAGIC-COOKIE-1", |
| 191 | +AuthCookie:hex.EncodeToString([]byte(fmt.Sprintf("cookie%d",i))), |
| 192 | +ScreenNumber:uint32(0), |
| 193 | +})) |
| 194 | +require.NoError(t,err) |
| 195 | + |
| 196 | +stdin,err:=sess.StdinPipe() |
| 197 | +require.NoError(t,err) |
| 198 | +stdout,err:=sess.StdoutPipe() |
| 199 | +require.NoError(t,err) |
| 200 | +stderr,err:=sess.StderrPipe() |
| 201 | +require.NoError(t,err) |
| 202 | +require.NoError(t,sess.Shell()) |
| 203 | + |
| 204 | +// The SSH server lazily starts the session. We need to write a command |
| 205 | +// and read back to ensure the X11 forwarding is started. |
| 206 | +scanner:=bufio.NewScanner(stdout) |
| 207 | +msg:=fmt.Sprintf("ready-%d",i) |
| 208 | +_,err=stdin.Write([]byte("echo "+msg+"\n")) |
| 209 | +require.NoError(t,err) |
| 210 | +// Read until we get the message (first token may be empty due to shell prompt) |
| 211 | +forscanner.Scan() { |
| 212 | +line:=strings.TrimSpace(scanner.Text()) |
| 213 | +ifstrings.Contains(line,msg) { |
| 214 | +break |
| 215 | +} |
| 216 | +} |
| 217 | +require.NoError(t,scanner.Err()) |
| 218 | + |
| 219 | +sessions=append(sessions,shellSession{ |
| 220 | +sess:sess, |
| 221 | +stdin:stdin, |
| 222 | +stdout:stdout, |
| 223 | +stderr:stderr, |
| 224 | +scanner:scanner, |
| 225 | +}) |
| 226 | +} |
| 227 | + |
| 228 | +// Create one more session which should evict the first (LRU) session and |
| 229 | +// therefore reuse the very first display/port. |
| 230 | +extraSess,err:=c.NewSession() |
| 231 | +require.NoError(t,err) |
| 232 | + |
| 233 | +_,err=extraSess.SendRequest("x11-req",true,gossh.Marshal(ssh.X11{ |
| 234 | +AuthProtocol:"MIT-MAGIC-COOKIE-1", |
| 235 | +AuthCookie:hex.EncodeToString([]byte("extra")), |
| 236 | +ScreenNumber:uint32(0), |
| 237 | +})) |
| 238 | +require.NoError(t,err) |
| 239 | + |
| 240 | +// Ask the remote side for the DISPLAY value so we can extract the display |
| 241 | +// number that was assigned to this session. |
| 242 | +out,err:=extraSess.Output("echo DISPLAY=$DISPLAY") |
| 243 | +require.NoError(t,err) |
| 244 | + |
| 245 | +// Example output line: "DISPLAY=localhost:10.0". |
| 246 | +varnewDisplayNumberint |
| 247 | +{ |
| 248 | +sc:=bufio.NewScanner(bytes.NewReader(out)) |
| 249 | +forsc.Scan() { |
| 250 | +line:=strings.TrimSpace(sc.Text()) |
| 251 | +ifstrings.HasPrefix(line,"DISPLAY=") { |
| 252 | +parts:=strings.SplitN(line,":",2) |
| 253 | +require.Len(t,parts,2) |
| 254 | +displayPart:=parts[1] |
| 255 | +ifstrings.Contains(displayPart,".") { |
| 256 | +displayPart=strings.SplitN(displayPart,".",2)[0] |
| 257 | +} |
| 258 | +varconvErrerror |
| 259 | +newDisplayNumber,convErr=strconv.Atoi(displayPart) |
| 260 | +require.NoError(t,convErr) |
| 261 | +break |
| 262 | +} |
| 263 | +} |
| 264 | +require.NoError(t,sc.Err()) |
| 265 | +} |
| 266 | + |
| 267 | +// The display number should have wrapped around to the starting value. |
| 268 | +assert.Equal(t,agentssh.X11DefaultDisplayOffset,newDisplayNumber,"expected display number to be reused after eviction") |
| 269 | + |
| 270 | +// validate that the first session was torn down. |
| 271 | +_,err=sessions[0].stdin.Write([]byte("echo DISPLAY=$DISPLAY\n")) |
| 272 | +require.ErrorIs(t,err,io.EOF) |
| 273 | +err=sessions[0].sess.Wait() |
| 274 | +require.Error(t,err) |
| 275 | + |
| 276 | +// Cleanup. |
| 277 | +for_,sh:=rangesessions[1:] { |
| 278 | +err=sh.stdin.Close() |
| 279 | +require.NoError(t,err) |
| 280 | +err=sh.sess.Wait() |
| 281 | +require.NoError(t,err) |
| 282 | +} |
| 283 | +err=extraSess.Close() |
| 284 | +require.ErrorIs(t,err,io.EOF) |
| 285 | + |
| 286 | +err=s.Close() |
| 287 | +require.NoError(t,err) |
| 288 | +_=testutil.TryReceive(ctx,t,done) |
| 289 | +} |