Commita61a154

committed

Improve start option

1 parente692a18 commita61a154Copy full SHA for a61a154

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -688,7 +688,7 @@ func (a *agent) handleSSHSession(session ssh.Session) (retErr error) {`
`688`	`688`	`cmd.Env=append(cmd.Env,fmt.Sprintf("TERM=%s",sshPty.Term))`
`689`	`689`
`690`	`690`	// The pty package sets `SSH_TTY` on supported platforms.
`691`		`-ptty,process,err:=pty.Start(cmd,pty.WithPTYOptions(`
	`691`	`+ptty,process,err:=pty.Start(cmd,pty.WithPTYOption(`
`692`	`692`	`pty.WithSSHRequest(sshPty),`
`693`	`693`	`pty.WithLogger(slog.Stdlib(ctx,a.logger,slog.LevelInfo)),`
`694`	`694`	`))`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ var (`
`21`	`21`	`)`
`22`	`22`
`23`	`23`	`// See: https://docs.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session`
`24`		`-funcnewPty(opt...PTYOption) (PTY,error) {`
	`24`	`+funcnewPty(opt...Option) (PTY,error) {`
`25`	`25`	`varoptsptyOptions`
`26`	`26`	`for_,o:=rangeopt {`
`27`	`27`	`o(&opts)`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,10 +11,10 @@ type startOptions struct {`
`11`	`11`	`ptyOpts []Option`
`12`	`12`	`}`
`13`	`13`
`14`		`-//WithPTYOptions applies the given options to the underlying PTY.`
`15`		`-funcWithPTYOptions(opts...Option)StartOption {`
	`14`	`+//WithPTYOption applies the given options to the underlying PTY.`
	`15`	`+funcWithPTYOption(opts...Option)StartOption {`
`16`	`16`	`returnfunc(o*startOptions) {`
`17`		`-o.ptyOpts=opts`
	`17`	`+o.ptyOpts=append(o.ptyOpts,opts...)`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func TestStart(t *testing.T) {`
`43`	`43`
`44`	`44`	`t.Run("SSH_TTY",func(t*testing.T) {`
`45`	`45`	`t.Parallel()`
`46`		`-opts:=pty.WithPTYOptions(pty.WithSSHRequest(ssh.Pty{`
	`46`	`+opts:=pty.WithPTYOption(pty.WithSSHRequest(ssh.Pty{`
`47`	`47`	`Window: ssh.Window{`
`48`	`48`	`Width:80,`
`49`	`49`	`Height:24,`

Comments

(0)