Commita607d56

authored

chore: disable pgcoord (HA) when --in-memory (#12919)

* chore: disable pgcoord (HA) when --in-memoryHA does not make any sense while using in-memory database

1 parent838e8df commita607d56Copy full SHA for a607d56

File tree

-10

lines changed

-10

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -630,7 +630,13 @@ func (api *API) updateEntitlements(ctx context.Context) error {`
`630`	`630`
`631`	`631`	`ifinitial,changed,enabled:=featureChanged(codersdk.FeatureHighAvailability);shouldUpdate(initial,changed,enabled) {`
`632`	`632`	`varcoordinator agpltailnet.Coordinator`
`633`		`-ifenabled {`
	`633`	`+// If HA is enabled, but the database is in-memory, we can't actually`
	`634`	`+// run HA and the PG coordinator. So throw a log line, and continue to use`
	`635`	`+// the in memory AGPL coordinator.`
	`636`	`+ifenabled&&api.DeploymentValues.InMemoryDatabase.Value() {`
	`637`	`+api.Logger.Warn(ctx,"high availability is enabled, but cannot be configured due to the database being set to in-memory")`
	`638`	`+}`
	`639`	`+ifenabled&&!api.DeploymentValues.InMemoryDatabase.Value() {`
`634`	`640`	`haCoordinator,err:=tailnet.NewPGCoord(api.ctx,api.Logger,api.Pubsub,api.Database)`
`635`	`641`	`iferr!=nil {`
`636`	`642`	`api.Logger.Error(ctx,"unable to set up high availability coordinator",slog.Error(err))`

Lines changed: 2 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,6 @@`
`1`	`1`	`import{defineConfig}from"@playwright/test";`
`2`	`2`	`import*aspathfrom"path";`
`3`		`-import{`
`4`		`-coderMain,`
`5`		`-coderPort,`
`6`		`-coderdPProfPort,`
`7`		`-enterpriseLicense,`
`8`		`-gitAuth,`
`9`		`-}from"./constants";`
	`3`	`+import{coderMain,coderPort,coderdPProfPort,gitAuth}from"./constants";`
`10`	`4`
`11`	`5`	`exportconstwsEndpoint=process.env.CODER_E2E_WS_ENDPOINT;`
`12`	`6`
`@@ -54,8 +48,7 @@ export default defineConfig({`
`54`	`48`	`"--global-config $(mktemp -d -t e2e-XXXXXXXXXX)",`
`55`	`49`	`--access-url=http://localhost:${coderPort}`,
`56`	`50`	`--http-address=localhost:${coderPort}`,
`57`		-// Adding an enterprise license causes issues with pgcoord when running with `--in-memory`.
`58`		`-!enterpriseLicense&&"--in-memory",`
	`51`	`+"--in-memory",`
`59`	`52`	`"--telemetry=false",`
`60`	`53`	`"--dangerous-disable-rate-limits",`
`61`	`54`	`"--provisioner-daemons 10",`

Comments

(0)