Commita546a85

authored

fix(coderd): set default provisionerjobs limit to 50 (#16450)

1 parentb3b229c commita546a85Copy full SHA for a546a85

File tree

+10

-3

lines changed

+10

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ func (api API) handleAuthAndFetchProvisionerJobs(rw http.ResponseWriter, r htt`
`101`	`101`
`102`	`102`	`qp:=r.URL.Query()`
`103`	`103`	`p:=httpapi.NewQueryParamParser()`
`104`		`-limit:=p.PositiveInt32(qp,0,"limit")`
	`104`	`+limit:=p.PositiveInt32(qp,50,"limit")`
`105`	`105`	`status:=p.Strings(qp,nil,"status")`
`106`	`106`	`p.ErrorExcessParams(qp)`
`107`	`107`	`iflen(p.Errors)>0 {`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,13 @@ func TestProvisionerJobs(t *testing.T) {`
`63`	`63`	`TemplateVersionID:version.ID,`
`64`	`64`	`})`
`65`	`65`
	`66`	`+// Add more jobs than the default limit.`
	`67`	`+forrange60 {`
	`68`	`+dbgen.ProvisionerJob(t,db,nil, database.ProvisionerJob{`
	`69`	`+OrganizationID:owner.OrganizationID,`
	`70`	`+})`
	`71`	`+}`
	`72`	`+`
`66`	`73`	`t.Run("Single",func(t*testing.T) {`
`67`	`74`	`t.Parallel()`
`68`	`75`	`t.Run("OK",func(t*testing.T) {`
`@@ -82,12 +89,12 @@ func TestProvisionerJobs(t *testing.T) {`
`82`	`89`	`})`
`83`	`90`	`})`
`84`	`91`
`85`		`-t.Run("All",func(t*testing.T) {`
	`92`	`+t.Run("Default limit",func(t*testing.T) {`
`86`	`93`	`t.Parallel()`
`87`	`94`	`ctx:=testutil.Context(t,testutil.WaitMedium)`
`88`	`95`	`jobs,err:=templateAdminClient.OrganizationProvisionerJobs(ctx,owner.OrganizationID,nil)`
`89`	`96`	`require.NoError(t,err)`
`90`		`-require.Len(t,jobs,3)`
	`97`	`+require.Len(t,jobs,50)`
`91`	`98`	`})`
`92`	`99`
`93`	`100`	`t.Run("Status",func(t*testing.T) {`

Comments

(0)