Commita4d86e9

authored

fix(site): Don't handle 304 as error (#6655)

1 parent331a49b commita4d86e9Copy full SHA for a4d86e9

File tree

+11

-2

lines changed

site/src
- api
  - api.ts
- pages/TemplateSettingsPage
  - TemplateSettingsPage.tsx

+11

-2

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,13 @@ import * as Types from "./types"`
`4`	`4`	`import{DeploymentConfig}from"./types"`
`5`	`5`	`import*asTypesGenfrom"./typesGenerated"`
`6`	`6`
	`7`	`+// Adds 304 for the default axios validateStatus function`
	`8`	`+// https://github.com/axios/axios#handling-errors`
	`9`	`+// Check status here https://httpstatusdogs.com/`
	`10`	`+axios.defaults.validateStatus=(status)=>{`
	`11`	`+return(status>=200&&status<300)\|\|status===304`
	`12`	`+}`
	`13`	`+`
`7`	`14`	`exportconsthardCodedCSRFCookie=():string=>{`
`8`	`15`	`// This is a hard coded CSRF token/cookie pair for local development.`
`9`	`16`	`// In prod, the GoLang webserver generates a random cookie with a new token for`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,10 @@ export const TemplateSettingsPage: FC = () => {`
`18`	`18`	`context:{ templateName, organizationId},`
`19`	`19`	`actions:{`
`20`	`20`	`onSave:(_,{ data})=>{`
`21`		`-// Use the data.name because the template name can be changed`
`22`		-navigate(`/templates/${data.name}`)
	`21`	`+// Use the data.name because the template name can be changed. Since the`
	`22`	`+// API can return 304 if the template name is not changed, we use the`
	`23`	`+// templateName from the URL as default.`
	`24`	+navigate(`/templates/${data.name??templateName}`)
`23`	`25`	`},`
`24`	`26`	`},`
`25`	`27`	`})`

Comments

(0)