Commita17d3a1

committed

fix: address PR comments

1 parent6129dd9 commita17d3a1Copy full SHA for a17d3a1

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`ALTERTABLE ONLY workspaces`
`2`		`- DROP COLUMN autostart_schedule,`
`3`		`- DROP COLUMN autostop_schedule;`
	`2`	`+ DROP COLUMNIF EXISTSautostart_schedule,`
	`3`	`+ DROP COLUMNIF EXISTSautostop_schedule;`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`ALTERTABLE ONLY workspaces`
`2`		`- ADD COLUMN autostart_scheduletext DEFAULTNULL,`
`3`		`- ADD COLUMN autostop_scheduletext DEFAULTNULL;`
	`2`	`+ ADD COLUMNIF NOT EXISTSautostart_scheduletext DEFAULTNULL,`
	`3`	`+ ADD COLUMNIF NOT EXISTSautostop_scheduletext DEFAULTNULL;`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,10 @@ func TestWorkspaceUpdateAutostart(t *testing.T) {`
`308`	`308`	`)`
`309`	`309`
`310`	`310`	`err:=client.UpdateWorkspaceAutostart(ctx,wsid,req)`
`311`		`-require.EqualError(t,err,fmt.Sprintf("status code 404: workspace %q does not exist",wsid),"unexpected error")`
	`311`	`+require.IsType(t,err,&codersdk.Error{},"expected codersdk.Error")`
	`312`	`+coderSDKErr,_:=err.(*codersdk.Error)`
	`313`	`+require.Equal(t,coderSDKErr.StatusCode(),404,"expected status code 404")`
	`314`	`+require.Equal(t,fmt.Sprintf("workspace %q does not exist",wsid),coderSDKErr.Message,"unexpected response code")`
`312`	`315`	`})`
`313`	`316`	`}`
`314`	`317`

Comments

(0)