Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita160e8f

Browse files
authored
chore(coderd): remove the window option in open_in (#16104)
As we worked on adding a `open_in` parameter for workspace_apps - weinitially created three options :- window- slim_window- tabAfter further investigation, `window` should not be used and has to beremoved.ℹ️ I decided to remove the option instead of deprecating it as we've notcreated any release nor documented the feature. Can be discussed.
1 parentb4fde80 commita160e8f

File tree

12 files changed

+27
-41
lines changed

12 files changed

+27
-41
lines changed

‎coderd/apidoc/docs.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎coderd/apidoc/swagger.json

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎coderd/provisionerdserver/provisionerdserver.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2017,8 +2017,8 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
20172017
switchapp.OpenIn {
20182018
casesdkproto.AppOpenIn_TAB:
20192019
openIn=database.WorkspaceAppOpenInTab
2020-
casesdkproto.AppOpenIn_WINDOW:
2021-
openIn=database.WorkspaceAppOpenInWindow
2020+
casesdkproto.AppOpenIn_SLIM_WINDOW:
2021+
openIn=database.WorkspaceAppOpenInSlimWindow
20222022
}
20232023

20242024
dbApp,err:=db.InsertWorkspaceApp(ctx, database.InsertWorkspaceAppParams{

‎codersdk/workspaceapps.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,11 @@ type WorkspaceAppOpenIn string
3838

3939
const (
4040
WorkspaceAppOpenInSlimWindowWorkspaceAppOpenIn="slim-window"
41-
WorkspaceAppOpenInWindowWorkspaceAppOpenIn="window"
4241
WorkspaceAppOpenInTabWorkspaceAppOpenIn="tab"
4342
)
4443

4544
varMapWorkspaceAppOpenIns=map[WorkspaceAppOpenIn]struct{}{
4645
WorkspaceAppOpenInSlimWindow: {},
47-
WorkspaceAppOpenInWindow: {},
4846
WorkspaceAppOpenInTab: {},
4947
}
5048

‎docs/reference/api/builds.md

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎docs/reference/api/schemas.md

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎docs/reference/api/templates.md

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎provisioner/terraform/resources.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,8 +437,6 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s
437437
switchstrings.ToLower(attrs.OpenIn) {
438438
case"slim-window":
439439
openIn=proto.AppOpenIn_SLIM_WINDOW
440-
case"window":
441-
openIn=proto.AppOpenIn_WINDOW
442440
case"tab":
443441
openIn=proto.AppOpenIn_TAB
444442
}

‎provisionersdk/proto/provisioner.pb.go

Lines changed: 20 additions & 19 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎provisionersdk/proto/provisioner.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ message Script {
164164
}
165165

166166
enumAppOpenIn {
167-
WINDOW=0;
167+
WINDOW=0 [deprecated =true];
168168
SLIM_WINDOW=1;
169169
TAB=2;
170170
}

‎site/e2e/provisionerGenerated.ts

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎site/src/api/typesGenerated.ts

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp