Commit9f75609

authored

Apply suggestions from code review

1 parent8b18611 commit9f75609Copy full SHA for 9f75609

File tree

+17

-21

lines changed

+17

-21

lines changed

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -178,19 +178,15 @@ func (q *querier) authorizePrebuiltWorkspace(ctx context.Context, action policy.`
`178`	`178`	`// authorizeAIBridgeInterceptionUpdate validates that the context's actor matches the initiator of the AIBridgeInterception.`
`179`	`179`	`// This is used by all of the sub-resources which fall under the [ResourceAibridgeInterception] umbrella.`
`180`	`180`	`func (q*querier)authorizeAIBridgeInterceptionUpdate(ctx context.Context,interceptionID uuid.UUID)error {`
`181`		`-act,ok:=ActorFromContext(ctx)`
`182`		`-if!ok {`
`183`		`-returnErrNoActor`
`184`		`-}`
`185`	`181`
`186`	`182`	`inter,err:=q.db.GetAIBridgeInterceptionByID(ctx,interceptionID)`
`187`	`183`	`iferr!=nil {`
`188`	`184`	`returnxerrors.Errorf("fetch aibridge interception %q: %w",interceptionID,err)`
`189`	`185`	`}`
`190`	`186`
`191`		`-err=q.auth.Authorize(ctx,act,policy.ActionUpdate,inter.RBACObject())`
`192`		`-iferr!=nil {`
`193`		`-returnlogNotAuthorizedError(ctx,q.log,err)`
	`187`	`+err=q.authorizeContext(ctx,policy.ActionUpdate,inter.RBACObject())`
	`188`	`+iferr!=nil {`
	`189`	`+returnerr`
`194`	`190`	`}`
`195`	`191`
`196`	`192`	`returnnil`

Lines changed: 14 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -888,20 +888,20 @@ func TestRolePermissions(t *testing.T) {`
`888`	`888`	`},`
`889`	`889`	`},`
`890`	`890`	`},`
`891`		`-{`
`892`		`-Name:"AIBridgeInterceptions",`
`893`		`-Actions: []policy.Action{policy.ActionCreate,policy.ActionRead,policy.ActionUpdate},`
`894`		`-Resource:rbac.ResourceAibridgeInterception,`
`895`		`-AuthorizeMap:map[bool][]hasAuthSubjects{`
`896`		`-true: {owner},`
`897`		`-false: {`
`898`		`-memberMe,orgMemberMe,otherOrgMember,`
`899`		`-orgAdmin,otherOrgAdmin,`
`900`		`-orgAuditor,otherOrgAuditor,`
`901`		`-templateAdmin,orgTemplateAdmin,otherOrgTemplateAdmin,`
`902`		`-userAdmin,orgUserAdmin,otherOrgUserAdmin,`
`903`		`-},`
`904`		`-},`
	`891`	`+{`
	`892`	`+Name:"AIBridgeInterceptions",`
	`893`	`+Actions: []policy.Action{policy.ActionCreate,policy.ActionRead,policy.ActionUpdate},`
	`894`	`+Resource:rbac.ResourceAibridgeInterception.WithOwner(currentUser.String()),`
	`895`	`+AuthorizeMap:map[bool][]hasAuthSubjects{`
	`896`	`+true: {owner,memberMe,orgMemberMe},`
	`897`	`+false: {`
	`898`	`+otherOrgMember,`
	`899`	`+orgAdmin,otherOrgAdmin,`
	`900`	`+orgAuditor,otherOrgAuditor,`
	`901`	`+templateAdmin,orgTemplateAdmin,otherOrgTemplateAdmin,`
	`902`	`+userAdmin,orgUserAdmin,otherOrgUserAdmin,`
	`903`	`+},`
	`904`	`+},`
`905`	`905`	`},`
`906`	`906`	`}`
`907`	`907`

Comments

(0)