NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

Commit9e5c83a

authored

fix: fix flakes in TestWorkspaceAutobuild due to incorrect tick time (#19398)

we missed these in the previous PR, we find `tickTime2`and pass it to the `tickCh`, but we were incorrectly passing `tickTime`to `UpdateProvisionerLastSeenAt` in some placesSigned-off-by: Callum Styan <callumstyan@gmail.com>

1 parentb6abcba commit9e5c83aCopy full SHA for 9e5c83a

File tree

1 file changed

-1

lines changed

enterprise/coderd
- workspaces_test.go

1 file changed

-1

lines changed

`‎enterprise/coderd/workspaces_test.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1277,7 +1277,7 @@ func TestWorkspaceAutobuild(t *testing.T) {`
`1277`	`1277`
`1278`	`1278`	`// We should see the workspace get stopped now.`
`1279`	`1279`	`tickTime2:=ws.LastUsedAt.Add(inactiveTTL*2)`
`1280`		`-coderdtest.UpdateProvisionerLastSeenAt(t,db,p.ID,tickTime)`
	`1280`	`+coderdtest.UpdateProvisionerLastSeenAt(t,db,p.ID,tickTime2)`
`1281`	`1281`	`tickCh<-tickTime2`
`1282`	`1282`	`stats=<-statsCh`
`1283`	`1283`	`require.Len(t,stats.Errors,0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9e5c83a

File tree

1 file changed

1 file changed

`‎enterprise/coderd/workspaces_test.go‎`

0 commit comments