NotificationsYou must be signed in to change notification settings
Fork914
Star10.1k

Commit9c62547

authored

fix(examples): add keep_locally to docker_image resources (#16012)

Fixes#15972Adds `keep_locally = true` to other templates that use the`docker_image` resource to prevent the docker provider from attemptingto remove the image upon workspace deletion.We had set this in some other places (such as the `dogfood` template)but had not set this consistently in other templates.

1 parentf3fe3bc commit9c62547Copy full SHA for 9c62547

File tree

3 files changed

-1

lines changed

examples
- jfrog/docker
  - main.tf
- parameters
  - main.tf
- templates/docker-devcontainer
  - main.tf

3 files changed

-1

lines changed

`‎examples/jfrog/docker/main.tf`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ resource "docker_image" "main" {`
`144`	`144`	`triggers={`
`145`	`145`	`dir_sha1=sha1(join("", [forfinfileset(path.module,"build/*"):filesha1("${path.module}/${f}")]))`
`146`	`146`	`}`
	`147`	`+keep_locally=true`
`147`	`148`	`}`
`148`	`149`
`149`	`150`	`resource"docker_container""workspace" {`

`‎examples/parameters/main.tf`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ resource "docker_image" "main" {`
`92`	`92`	`triggers={`
`93`	`93`	`dir_sha1=sha1(join("", [forfinfileset(path.module,"build/*"):filesha1(f)]))`
`94`	`94`	`}`
	`95`	`+keep_locally=true`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`resource"docker_container""workspace" {`

`‎examples/templates/docker-devcontainer/main.tf`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,8 @@ data "local_sensitive_file" "cache_repo_dockerconfigjson" {`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`resource"docker_image""devcontainer_builder_image" {`
`157`		`-name=local.devcontainer_builder_image`
	`157`	`+name=local.devcontainer_builder_image`
	`158`	`+keep_locally=true`
`158`	`159`	`}`
`159`	`160`
`160`	`161`	`resource"docker_volume""workspaces" {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9c62547

File tree

3 files changed

3 files changed

`‎examples/jfrog/docker/main.tf`

`‎examples/parameters/main.tf`

`‎examples/templates/docker-devcontainer/main.tf`

0 commit comments