Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9bfa415

Browse files
authored
add test for creating a forbidden template (#4371)
1 parentb920801 commit9bfa415

File tree

3 files changed

+73
-2
lines changed

3 files changed

+73
-2
lines changed

‎coderd/authorize.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ package coderd
22

33
import (
44
"fmt"
5-
"github.com/google/uuid"
65
"net/http"
76

7+
"github.com/google/uuid"
8+
89
"golang.org/x/xerrors"
910

1011
"cdr.dev/slog"

‎coderd/database/modelqueries.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ import (
55
"encoding/json"
66
"fmt"
77

8-
"github.com/coder/coder/coderd/rbac"
98
"github.com/lib/pq"
109

10+
"github.com/coder/coder/coderd/rbac"
11+
1112
"github.com/google/uuid"
1213
"golang.org/x/xerrors"
1314
)

‎enterprise/coderd/workspaces_test.go

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
package coderd_test
2+
3+
import (
4+
"context"
5+
"net/http"
6+
"testing"
7+
"time"
8+
9+
"github.com/stretchr/testify/require"
10+
11+
"github.com/coder/coder/coderd/coderdtest"
12+
"github.com/coder/coder/coderd/util/ptr"
13+
"github.com/coder/coder/codersdk"
14+
"github.com/coder/coder/enterprise/coderd/coderdenttest"
15+
"github.com/coder/coder/testutil"
16+
)
17+
18+
funcTestCreateWorkspace(t*testing.T) {
19+
t.Parallel()
20+
21+
// Test that a user cannot indirectly access
22+
// a template they do not have access to.
23+
t.Run("Unauthorized",func(t*testing.T) {
24+
t.Parallel()
25+
26+
client:=coderdenttest.New(t,nil)
27+
user:=coderdtest.CreateFirstUser(t,client)
28+
_=coderdenttest.AddLicense(t,client, coderdenttest.LicenseOptions{
29+
RBACEnabled:true,
30+
})
31+
32+
version:=coderdtest.CreateTemplateVersion(t,client,user.OrganizationID,nil)
33+
template:=coderdtest.CreateTemplate(t,client,user.OrganizationID,version.ID)
34+
35+
ctx,cancel:=context.WithTimeout(context.Background(),testutil.WaitLong)
36+
defercancel()
37+
38+
acl,err:=client.TemplateACL(ctx,template.ID)
39+
require.NoError(t,err)
40+
41+
require.Len(t,acl.Groups,1)
42+
require.Len(t,acl.Users,0)
43+
44+
err=client.UpdateTemplateACL(ctx,template.ID, codersdk.UpdateTemplateACL{
45+
GroupPerms:map[string]codersdk.TemplateRole{
46+
acl.Groups[0].ID.String():codersdk.TemplateRoleDeleted,
47+
},
48+
})
49+
require.NoError(t,err)
50+
51+
client1,user1:=coderdtest.CreateAnotherUserWithUser(t,client,user.OrganizationID)
52+
53+
_,err=client1.Template(ctx,template.ID)
54+
require.Error(t,err)
55+
cerr,ok:=codersdk.AsError(err)
56+
require.True(t,ok)
57+
require.Equal(t,http.StatusNotFound,cerr.StatusCode())
58+
59+
req:= codersdk.CreateWorkspaceRequest{
60+
TemplateID:template.ID,
61+
Name:"testme",
62+
AutostartSchedule:ptr.Ref("CRON_TZ=US/Central 30 9 * * 1-5"),
63+
TTLMillis:ptr.Ref((8*time.Hour).Milliseconds()),
64+
}
65+
66+
_,err=client1.CreateWorkspace(ctx,user.OrganizationID,user1.ID.String(),req)
67+
require.Error(t,err)
68+
})
69+
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp