Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9b43703

Browse files
authored
feat: remove workspace_actions experiment (#11427)
1 parent04afb88 commit9b43703

22 files changed

+26
-119
lines changed

‎cli/templatecreate.go‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,6 @@ func (r *RootCmd) templateCreate() *clibase.Cmd {
4949
isTemplateSchedulingOptionsSet:=failureTTL!=0||dormancyThreshold!=0||dormancyAutoDeletion!=0||maxTTL!=0
5050

5151
ifisTemplateSchedulingOptionsSet||requireActiveVersion {
52-
iffailureTTL!=0||dormancyThreshold!=0||dormancyAutoDeletion!=0 {
53-
// This call can be removed when workspace_actions is no longer experimental
54-
experiments,exErr:=client.Experiments(inv.Context())
55-
ifexErr!=nil {
56-
returnxerrors.Errorf("get experiments: %w",exErr)
57-
}
58-
59-
if!experiments.Enabled(codersdk.ExperimentWorkspaceActions) {
60-
returnxerrors.Errorf("--failure-ttl, --dormancy-threshold, and --dormancy-auto-deletion are experimental features. Use the workspace_actions CODER_EXPERIMENTS flag to set these configuration values.")
61-
}
62-
}
63-
6452
entitlements,err:=client.Entitlements(inv.Context())
6553
ifcerr,ok:=codersdk.AsError(err);ok&&cerr.StatusCode()==http.StatusNotFound {
6654
returnxerrors.Errorf("your deployment appears to be an AGPL deployment, so you cannot set enterprise-only flags")

‎cli/templateedit.go‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,6 @@ func (r *RootCmd) templateEdit() *clibase.Cmd {
4747
),
4848
Short:"Edit the metadata of a template by name.",
4949
Handler:func(inv*clibase.Invocation)error {
50-
// This clause can be removed when workspace_actions is no longer experimental
51-
iffailureTTL!=0||dormancyThreshold!=0||dormancyAutoDeletion!=0 {
52-
experiments,exErr:=client.Experiments(inv.Context())
53-
ifexErr!=nil {
54-
returnxerrors.Errorf("get experiments: %w",exErr)
55-
}
56-
57-
if!experiments.Enabled(codersdk.ExperimentWorkspaceActions) {
58-
returnxerrors.Errorf("--failure-ttl, --dormancy-threshold, and --dormancy-auto-deletion are experimental features. Use the workspace_actions CODER_EXPERIMENTS flag to set these configuration values.")
59-
}
60-
}
61-
6250
unsetAutostopRequirementDaysOfWeek:=len(autostopRequirementDaysOfWeek)==1&&autostopRequirementDaysOfWeek[0]=="none"
6351
requiresScheduling:= (len(autostopRequirementDaysOfWeek)>0&&!unsetAutostopRequirementDaysOfWeek)||
6452
autostopRequirementWeeks>0||

‎coderd/apidoc/docs.go‎

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎coderd/apidoc/swagger.json‎

Lines changed: 2 additions & 5 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎codersdk/deployment.go‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2077,9 +2077,6 @@ func (c *Client) BuildInfo(ctx context.Context) (BuildInfoResponse, error) {
20772077
typeExperimentstring
20782078

20792079
const (
2080-
// https://github.com/coder/coder/milestone/19
2081-
ExperimentWorkspaceActionsExperiment="workspace_actions"
2082-
20832080
// Deployment health page
20842081
ExperimentDeploymentHealthPageExperiment="deployment_health_page"
20852082

‎docs/api/general.md‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎docs/api/schemas.md‎

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

‎enterprise/cli/templatecreate_test.go‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,19 +62,13 @@ func TestTemplateCreate(t *testing.T) {
6262
t.Run("WorkspaceCleanup",func(t*testing.T) {
6363
t.Parallel()
6464

65-
dv:=coderdtest.DeploymentValues(t)
66-
dv.Experiments= []string{
67-
string(codersdk.ExperimentWorkspaceActions),
68-
}
69-
7065
client,user:=coderdenttest.New(t,&coderdenttest.Options{
7166
LicenseOptions:&coderdenttest.LicenseOptions{
7267
Features: license.Features{
7368
codersdk.FeatureAdvancedTemplateScheduling:1,
7469
},
7570
},
7671
Options:&coderdtest.Options{
77-
DeploymentValues:dv,
7872
IncludeProvisionerDaemon:true,
7973
},
8074
})

‎enterprise/cli/templateedit_test.go‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,19 +89,13 @@ func TestTemplateEdit(t *testing.T) {
8989
t.Run("WorkspaceCleanup",func(t*testing.T) {
9090
t.Parallel()
9191

92-
dv:=coderdtest.DeploymentValues(t)
93-
dv.Experiments= []string{
94-
string(codersdk.ExperimentWorkspaceActions),
95-
}
96-
9792
ownerClient,owner:=coderdenttest.New(t,&coderdenttest.Options{
9893
LicenseOptions:&coderdenttest.LicenseOptions{
9994
Features: license.Features{
10095
codersdk.FeatureAdvancedTemplateScheduling:1,
10196
},
10297
},
10398
Options:&coderdtest.Options{
104-
DeploymentValues:dv,
10599
IncludeProvisionerDaemon:true,
106100
},
107101
})

‎site/src/api/typesGenerated.ts‎

Lines changed: 2 additions & 5 deletions
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp