Commit9acf6ac

authored

test: use static port for Prometheus (#14972)

1 parent4369f2b commit9acf6acCopy full SHA for 9acf6ac

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,10 +59,11 @@ func Test_ProxyServer_Headers(t *testing.T) {`
`59`	`59`	`assert.EqualValues(t,1,atomic.LoadInt64(&called))`
`60`	`60`	`}`
`61`	`61`
	`62`	`+//nolint:paralleltest,tparallel // Test uses a static port.`
`62`	`63`	`funcTestWorkspaceProxy_Server_PrometheusEnabled(t*testing.T) {`
`63`		`-t.Parallel()`
`64`		`-`
`65`		`-prometheusPort:=testutil.RandomPort(t)`
	`64`	+// Ephemeral ports have a tendency to conflict and fail with `bind: address already in use` error.
	`65`	`+// This workaround forces a static port for Prometheus that hopefully won't be used by other tests.`
	`66`	`+prometheusPort:=32002`
`66`	`67`
`67`	`68`	`varwg sync.WaitGroup`
`68`	`69`	`wg.Add(1)`

Comments

(0)