Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit9924b8e

Browse files
committed
pr feedback
1 parent0e8dcfb commit9924b8e

File tree

1 file changed

+22
-16
lines changed

1 file changed

+22
-16
lines changed

‎coderd/aitasks_test.go‎

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -277,22 +277,24 @@ func TestTasks(t *testing.T) {
277277
user:=coderdtest.CreateFirstUser(t,client)
278278
template:=createAITemplate(t,client,user)
279279

280-
ws:=coderdtest.CreateWorkspace(t,client,template.ID,func(req*codersdk.CreateWorkspaceRequest) {
281-
req.RichParameterValues= []codersdk.WorkspaceBuildParameter{
282-
{Name:codersdk.AITaskPromptParameterName,Value:"delete-me"},
283-
}
284-
})
285-
coderdtest.AwaitWorkspaceBuildJobCompleted(t,client,ws.LatestBuild.ID)
286-
287280
ctx:=testutil.Context(t,testutil.WaitLong)
288281

289282
exp:=codersdk.NewExperimentalClient(client)
290-
err:=exp.DeleteTask(ctx,"me",ws.ID)
283+
task,err:=exp.CreateTask(ctx,"me", codersdk.CreateTaskRequest{
284+
TemplateVersionID:template.ActiveVersionID,
285+
Prompt:"delete me",
286+
})
287+
require.NoError(t,err)
288+
ws,err:=client.Workspace(ctx,task.ID)
289+
require.NoError(t,err)
290+
coderdtest.AwaitWorkspaceBuildJobCompleted(t,client,ws.LatestBuild.ID)
291+
292+
err=exp.DeleteTask(ctx,"me",task.ID)
291293
require.NoError(t,err,"delete task request should be accepted")
292294

293295
// Poll until the workspace is deleted.
294296
for {
295-
dws,derr:=client.DeletedWorkspace(ctx,ws.ID)
297+
dws,derr:=client.DeletedWorkspace(ctx,task.ID)
296298
ifderr==nil&&dws.LatestBuild.Status==codersdk.WorkspaceStatusDeleted {
297299
break
298300
}
@@ -354,21 +356,25 @@ func TestTasks(t *testing.T) {
354356

355357
// Owner's AI-capable template and workspace (task).
356358
template:=createAITemplate(t,client,owner)
357-
ws:=coderdtest.CreateWorkspace(t,client,template.ID,func(req*codersdk.CreateWorkspaceRequest) {
358-
req.RichParameterValues= []codersdk.WorkspaceBuildParameter{
359-
{Name:codersdk.AITaskPromptParameterName,Value:"secure"},
360-
}
361-
})
362-
coderdtest.AwaitWorkspaceBuildJobCompleted(t,client,ws.LatestBuild.ID)
363359

364360
ctx:=testutil.Context(t,testutil.WaitShort)
365361

362+
exp:=codersdk.NewExperimentalClient(client)
363+
task,err:=exp.CreateTask(ctx,"me", codersdk.CreateTaskRequest{
364+
TemplateVersionID:template.ActiveVersionID,
365+
Prompt:"delete me not",
366+
})
367+
require.NoError(t,err)
368+
ws,err:=client.Workspace(ctx,task.ID)
369+
require.NoError(t,err)
370+
coderdtest.AwaitWorkspaceBuildJobCompleted(t,client,ws.LatestBuild.ID)
371+
366372
// Another regular org member without elevated permissions.
367373
otherClient,_:=coderdtest.CreateAnotherUser(t,client,owner.OrganizationID)
368374
expOther:=codersdk.NewExperimentalClient(otherClient)
369375

370376
// Attempt to delete the owner's task as a non-owner without permissions.
371-
err:=expOther.DeleteTask(ctx,"me",ws.ID)
377+
err=expOther.DeleteTask(ctx,"me",task.ID)
372378

373379
varauthErr*codersdk.Error
374380
require.Error(t,err,"expected an authorization error when deleting another user's task")

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp