Commit98c6e64

authored and

committed

fix: return http 204 on test notification (#16651)

This PR changes the API response for `/api/v2/notifications/test`endpoint to HTTP 204 / No Content.

1 parentfd68a63 commit98c6e64Copy full SHA for 98c6e64

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ func (api API) postTestNotification(rw http.ResponseWriter, r http.Request) {`
`210`	`210`	`return`
`211`	`211`	`}`
`212`	`212`
`213`		`-httpapi.Write(ctx,rw,http.StatusOK,nil)`
	`213`	`+rw.WriteHeader(http.StatusNoContent)`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`// @Summary Get user notification preferences`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -200,10 +200,9 @@ func (c *Client) PostTestNotification(ctx context.Context) error {`
`200`	`200`	`}`
`201`	`201`	`deferres.Body.Close()`
`202`	`202`
`203`		`-ifres.StatusCode!=http.StatusOK {`
	`203`	`+ifres.StatusCode!=http.StatusNoContent {`
`204`	`204`	`returnReadBodyAsError(res)`
`205`	`205`	`}`
`206`		`-`
`207`	`206`	`returnnil`
`208`	`207`	`}`
`209`	`208`

Comments

(0)