Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9861931

Browse files
fix: select the correct version when template changes (#20293)
Fixcoder/internal#1062
1 parent24dddd5 commit9861931

File tree

2 files changed

+69
-11
lines changed

2 files changed

+69
-11
lines changed

‎site/src/modules/tasks/TaskPrompt/TaskPrompt.stories.tsx‎

Lines changed: 64 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@ const meta: Meta<typeof TasksPage> = {
3030
},
3131
beforeEach:()=>{
3232
spyOn(API,"getTemplateVersionExternalAuth").mockResolvedValue([]);
33-
spyOn(API,"getTemplates").mockResolvedValue([
34-
MockTemplate,
35-
{
36-
...MockTemplate,
37-
id:"test-template-2",
38-
name:"template 2",
39-
display_name:"Template 2",
40-
},
41-
]);
4233
spyOn(API,"getTemplateVersions").mockResolvedValue([
4334
{
4435
...MockTemplateVersion,
@@ -126,6 +117,70 @@ export const OnSuccess: Story = {
126117
},
127118
};
128119

120+
exportconstChangeTemplate:Story={
121+
decorators:[withGlobalSnackbar],
122+
args:{
123+
templates:[
124+
{
125+
...MockTemplate,
126+
id:"claude-code",
127+
name:"claude-code",
128+
display_name:"Claude Code",
129+
active_version_id:"claude-code-version",
130+
},
131+
{
132+
...MockTemplate,
133+
id:"codex",
134+
name:"codex",
135+
display_name:"Codex",
136+
active_version_id:"codex-version",
137+
},
138+
],
139+
},
140+
beforeEach:()=>{
141+
spyOn(API,"getTemplateVersions").mockImplementation((templateId)=>{
142+
if(templateId==="claude-code"){
143+
returnPromise.resolve([
144+
{
145+
...MockTemplateVersion,
146+
id:"claude-code-version",
147+
name:"claude-code-version",
148+
},
149+
]);
150+
}
151+
if(templateId==="codex"){
152+
returnPromise.resolve([
153+
{
154+
...MockTemplateVersion,
155+
id:"codex-version",
156+
name:"codex-version",
157+
},
158+
]);
159+
}
160+
returnPromise.resolve([]);
161+
});
162+
spyOn(API.experimental,"createTask").mockResolvedValue(MockTask);
163+
},
164+
play:async({ canvasElement, step})=>{
165+
constcanvas=within(canvasElement);
166+
constbody=within(canvasElement.ownerDocument.body);
167+
168+
awaitstep("Change template",async()=>{
169+
consttemplateSelect=awaitcanvas.findByLabelText(/selecttemplate/i);
170+
awaituserEvent.click(templateSelect);
171+
consttemplateOption=awaitbody.findByRole("option",{
172+
name:/codex/i,
173+
});
174+
awaituserEvent.click(templateOption);
175+
});
176+
177+
awaitstep("Default version is selected",async()=>{
178+
constversionSelect=awaitcanvas.findByLabelText(/version/i);
179+
expect(versionSelect).toHaveTextContent("codex-version");
180+
});
181+
},
182+
};
183+
129184
exportconstSelectTemplateVersion:Story={
130185
decorators:[withGlobalSnackbar],
131186
beforeEach:()=>{

‎site/src/modules/tasks/TaskPrompt/TaskPrompt.tsx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ const CreateTaskForm: FC<CreateTaskFormProps> = ({ templates, onSuccess }) => {
165165
...templateVersions(selectedTemplate.id),
166166
enabled:permissions.updateTemplates,
167167
});
168+
useEffect(()=>{
169+
setSelectedVersionId(selectedTemplate.active_version_id);
170+
},[selectedTemplate]);
168171

169172
// Presets
170173
const{data:presets,isLoading:isLoadingPresets}=useQuery(
@@ -269,7 +272,7 @@ const CreateTaskForm: FC<CreateTaskFormProps> = ({ templates, onSuccess }) => {
269272
<divclassName="flex items-center gap-1">
270273
<div>
271274
<labelhtmlFor="templateID"className="sr-only">
272-
Template
275+
Select template
273276
</label>
274277
<Select
275278
name="templateID"
@@ -326,7 +329,7 @@ const CreateTaskForm: FC<CreateTaskFormProps> = ({ templates, onSuccess }) => {
326329
Preset
327330
</label>
328331
{isLoadingPresets ?(
329-
<SkeletonclassName="w-[320px] h-8"/>
332+
<SkeletonclassName="w-[140px] h-8 rounded-full"/>
330333
) :(
331334
presets&&
332335
presets.length>0&&

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp