NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.6k

Commit9398e0d

committed

fix: prevent infinite renders in CreateWorkspacePageView by replacing useEffect with useEffectEvent

1 parentd843fa9 commit9398e0dCopy full SHA for 9398e0d

File tree

1 file changed

-10

lines changed

site/src/pages/CreateWorkspacePage
- CreateWorkspacePageView.tsx

1 file changed

-10

lines changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx‎`

Lines changed: 5 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ import { Stack } from "components/Stack/Stack";`
`26`	`26`	`import{Switch}from"components/Switch/Switch";`
`27`	`27`	`import{UserAutocomplete}from"components/UserAutocomplete/UserAutocomplete";`
`28`	`28`	`import{typeFormikContextType,useFormik}from"formik";`
	`29`	`+import{useEffectEvent}from"hooks/hookPolyfills";`
`29`	`30`	`importtype{ExternalAuthPollingState}from"hooks/useExternalAuth";`
`30`	`31`	`import{ExternalLinkIcon}from"lucide-react";`
`31`	`32`	`import{linkToTemplate,useLinks}from"modules/navigation";`
`@@ -162,7 +163,7 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({`
`162`	`163`	`]);`
`163`	`164`	`const[selectedPresetIndex,setSelectedPresetIndex]=useState(0);`
`164`	`165`	`// Build options and keep default label/value in sync`
`165`		`-useEffect(()=>{`
	`166`	`+useEffectEvent(()=>{`
`166`	`167`	`constoptions=[`
`167`	`168`	`{displayName:"None",value:"undefined",icon:"",description:""},`
`168`	`169`	`...presets.map((preset)=>({`
`@@ -182,12 +183,12 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({`
`182`	`183`	`setSelectedPresetIndex(0);// Explicitly set to "None"`
`183`	`184`	`form.setFieldValue("template_version_preset_id",undefined);`
`184`	`185`	`}`
`185`		`-},[presets,form.setFieldValue]);`
	`186`	`+});`
`186`	`187`
`187`	`188`	`const[presetParameterNames,setPresetParameterNames]=useState<string[]>(`
`188`	`189`	`[],`
`189`	`190`	`);`
`190`		`-useEffect(()=>{`
	`191`	`+useEffectEvent(()=>{`
`191`	`192`	`constselectedPresetOption=presetOptions[selectedPresetIndex];`
`192`	`193`	`letselectedPreset:TypesGen.Preset\|undefined;`
`193`	`194`	`for(constpresetofpresets){`
`@@ -217,13 +218,7 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({`
`217`	`218`	`value:presetParameter.Value,`
`218`	`219`	`});`
`219`	`220`	`}`
`220`		`-},[`
`221`		`-presetOptions,`
`222`		`-selectedPresetIndex,`
`223`		`-presets,`
`224`		`-parameters,`
`225`		`-form.setFieldValue,`
`226`		`-]);`
	`221`	`+});`
`227`	`222`
`228`	`223`	`return(`
`229`	`224`	`<Marginssize="medium">`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9398e0d

File tree

1 file changed

1 file changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx‎`

0 commit comments