Commit92befc0

committed

fix: show task display name in task topbar (#20957)

## DescriptionUpdate task topbar in task page to show display name, instead of taskname.Follow-up PR:#20918Related to internal slack thread:https://codercom.slack.com/archives/C0992H8HGCS/p1764086497375829(cherry picked from commit21efebe)

1 parentdfa25d5 commit92befc0Copy full SHA for 92befc0

File tree

+39

-4

lines changed

+39

-4

lines changed

Lines changed: 33 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`import{`
`2`	`2`	`MockDeletedWorkspace,`
	`3`	`+MockDisplayNameTasks,`
`3`	`4`	`MockFailedWorkspace,`
`4`	`5`	`MockStartingWorkspace,`
`5`	`6`	`MockStoppedWorkspace,`
`@@ -561,6 +562,38 @@ export const WorkspaceStartFailureWithDialog: Story = {`
`561`	`562`	`},`
`562`	`563`	`};`
`563`	`564`
	`565`	`+constlongDisplayName=`
	`566`	`+"Implement comprehensive authentication and authorization system with role-based access control";`
	`567`	`+exportconstLongDisplayName:Story={`
	`568`	`+parameters:{`
	`569`	`+queries:[`
	`570`	`+{`
	`571`	`+// Sidebar: uses getTasks() which returns an array`
	`572`	`+key:["tasks",{owner:MockTask.owner_name}],`
	`573`	`+data:[`
	`574`	`+{ ...MockDisplayNameTasks[0],display_name:longDisplayName},`
	`575`	`+...MockDisplayNameTasks.slice(1),`
	`576`	`+],`
	`577`	`+},`
	`578`	`+{`
	`579`	`+// TaskTopbar: uses getTask() which returns a single task`
	`580`	`+key:["tasks",MockTask.owner_name,MockTask.id],`
	`581`	`+data:{ ...MockDisplayNameTasks[0],display_name:longDisplayName},`
	`582`	`+},`
	`583`	`+{`
	`584`	`+// Workspace data for the task`
	`585`	`+key:[`
	`586`	`+"workspace",`
	`587`	`+MockTask.owner_name,`
	`588`	`+MockTask.workspace_name,`
	`589`	`+"settings",`
	`590`	`+],`
	`591`	`+data:MockWorkspace,`
	`592`	`+},`
	`593`	`+],`
	`594`	`+},`
	`595`	`+};`
	`596`	`+`
`564`	`597`	`functionmockTaskWithWorkspace(`
`565`	`598`	`sidebarApp:WorkspaceApp,`
`566`	`599`	`activeApp:WorkspaceApp,`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ type TaskTopbarProps = { task: Task; workspace: Workspace };`
`23`	`23`
`24`	`24`	`exportconstTaskTopbar:FC<TaskTopbarProps>=({ task, workspace})=>{`
`25`	`25`	`return(`
`26`		`-<headerclassName="flex flex-shrink-0 items-center p-3 border-solid border-border border-0 border-b">`
	`26`	`+<headerclassName="flex flex-shrink-0 items-centergap-2p-3 border-solid border-border border-0 border-b">`
`27`	`27`	`<TooltipProvider>`
`28`	`28`	`<Tooltip>`
`29`	`29`	`<TooltipTriggerasChild>`
`@@ -38,7 +38,9 @@ export const TaskTopbar: FC<TaskTopbarProps> = ({ task, workspace }) => {`
`38`	`38`	`</Tooltip>`
`39`	`39`	`</TooltipProvider>`
`40`	`40`
`41`		`-<h1className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1>`
	`41`	`+<h1className="m-0 pl-2 text-base font-medium max-w-[520px] truncate">`
	`42`	`+{task.display_name}`
	`43`	`+</h1>`
`42`	`44`
`43`	`45`	`{task.current_state?.uri&&(`
`44`	`46`	`<divclassName="flex items-center gap-2 flex-wrap ml-4">`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4971,8 +4971,8 @@ export const MockAIPromptPresets: TypesGen.Preset[] = [`
`4971`	`4971`
`4972`	`4972`	`exportconstMockTask={`
`4973`	`4973`	`id:"test-task",`
`4974`		`-name:"wild-test-123",`
`4975`		`-display_name:"Task wild test",`
	`4974`	`+name:"perform-some-task-123",`
	`4975`	`+display_name:"Perform some task",`
`4976`	`4976`	`organization_id:MockOrganization.id,`
`4977`	`4977`	`owner_id:MockUserOwner.id,`
`4978`	`4978`	`owner_name:MockUserOwner.username,`

Comments

(0)