NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.4k

Commit9298e7e

authored

chore: remove@emotion/react from<404Page /> (#20530)

This PR removes the dependency on `@emotion/react` from the 404 page aspart of our ongoing effort to eliminate `@mui/` dependencies across thecodebase.I’m slightly concerned that these Tailwind classes might not applycorrectly if Tailwind fails to load. If thats an issue, it might beworth converting this page to raw CSS.

1 parent7182c53 commit9298e7eCopy full SHA for 9298e7e

File tree

1 file changed

-20

lines changed

site/src/pages/404Page
- 404Page.tsx

1 file changed

-20

lines changed

`‎site/src/pages/404Page/404Page.tsx‎`

Lines changed: 5 additions & 20 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,26 +2,11 @@ import type { FC } from "react";`
`2`	`2`
`3`	`3`	`constNotFoundPage:FC=()=>{`
`4`	`4`	`return(`
`5`		`-<div`
`6`		`-css={{`
`7`		`-width:"100%",`
`8`		`-height:"100%",`
`9`		`-display:"flex",`
`10`		`-flexDirection:"row",`
`11`		`-justifyContent:"center",`
`12`		`-alignItems:"center",`
`13`		`-}}`
`14`		`->`
`15`		`-<div`
`16`		`-css={(theme)=>({`
`17`		`-margin:8,`
`18`		`-padding:8,`
`19`		`-borderRight:theme.palette.divider,`
`20`		`-})}`
`21`		`->`
`22`		`-<h4>404</h4>`
`23`		`-</div>`
`24`		`-<p>This page could not be found.</p>`
	`5`	`+<divclassName="w-full h-full flex flex-row justify-center items-center">`
	`6`	`+<pclassName="flex gap-4">`
	`7`	`+<spanclassName="font-bold">404</span>`
	`8`	`+This page could not be found.`
	`9`	`+</p>`
`25`	`10`	`</div>`
`26`	`11`	`);`
`27`	`12`	`};`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9298e7e

File tree

1 file changed

1 file changed

`‎site/src/pages/404Page/404Page.tsx‎`

0 commit comments